EXPTREE (JULY 17) [CPP] #197

NishantTanwar · 2017-10-03T10:54:21Z

Fixes #194

Pull Request Title is of form EXPTREE (JULY 17) [CPP].
This problem already had an entry in this repository.
- This solution is better than the one already in this repository.
This solution is prepared by me and not copied from anywhere else on the web.
I have added a copyright comment in my solution.
I have updated README.md file (in appropriate order).
I have read and followed Code Samples.
I understand that pull request will be closed if I failed to update it even once in a week.

aashutoshrathi · 2017-10-03T10:54:23Z

Hi! Thanks for contributing to this repository.
Make sure you have checked points in PR correctly.

NishantTanwar · 2017-10-03T11:18:32Z

@Monal5031 pls check PR #197 let me know if there is still some error

NishantTanwar · 2017-10-03T11:30:33Z

@aashutoshrathi @Monal5031 pls justify what is the exact error in my PR

Monal5031 · 2017-10-03T21:39:01Z

@NishantTanwar The problem is that you have use space indentations while in this repo we follow tabspaces for c and cpp files. Use tab indentation to pass all the tests.
Also don't get frightened over such long messages they are auto-generated issues raised gitmate bot.

Monal5031

Please remove the .idea files.

Monal5031 · 2017-10-03T21:39:48Z

.idea/misc.xml

@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>


Please remove these .idea files

Okay .. I am updating it

aashutoshrathi · 2017-10-05T18:11:12Z

@NishantTanwar Please make changes.

NishantTanwar · 2017-10-05T18:46:06Z

Yeah. I am updating it.

NishantTanwar · 2017-10-05T19:06:23Z

Please review @Monal5031 I have updated.

aashutoshrathi · 2017-10-05T19:11:14Z

Remove all unwanted files, make your indentation to tabs and add a new line to the end of the file, as soon as Travis Checks become successful, we will merge it.

NishantTanwar · 2017-10-05T19:16:24Z

But I guess I have given proper indentation to tabs and also removed the unwanted files

aashutoshrathi · 2017-10-05T19:22:44Z

No, your PR edits 6 files, while it should edit only 3 (including .gitignote).
And you file has space indentation, instead of Tabs (size 4).
Make necessary changes.

Monal5031 · 2017-10-05T21:53:36Z

2017/JULY/JULY17/CHEFSIGN/CHEFSIGN.cpp

@@ -6,6 +6,7 @@ using namespace std;

 int main() {

+


Please undo this change, as it is not part of your PR.

Monal5031 · 2017-10-05T21:53:49Z

2017/JULY/JULY17/EXPTREE/EXPTREE.cpp

+
+ll modinverse(ll val) {
+    return exponent(val, MOD - 2);
+}


Add a new line at end.

After which line number?

at the end of file.

Monal5031 · 2017-10-05T21:54:28Z

.gitignore

@@ -17,5 +17,6 @@
 *.class
 *.pyc
 *.html
+.idea/


Rather simply delete the .idea files for now and in another PR you can do this 😉

Monal5031 · 2017-10-10T22:08:45Z

ping @NishantTanwar Its been 5 days since this PR was last updated, please update it before time.

NishantTanwar · 2017-10-10T22:15:35Z

@Monal5031 I am not able to get those identation errors hence was not able to update it. I have reviewed my code many times and it seems that I have given tab indentation and not space identation

Monal5031 · 2017-10-10T22:20:00Z

@NishantTanwar If you want some help in indenting the code properly you can use coala locally, the command to run it locally on algos directory as

coala --apply-patches -n

but first you need to install coala using

pip3 install coala-bears

This will tab indent the code itself.

NishantTanwar · 2017-10-10T22:38:04Z

@Monal5031 I added a new line at the end but still didn't work.

Monal5031 · 2017-10-10T22:42:31Z

@NishantTanwar Did you try indenting the code using coala, because the space indentation error still persists.

NishantTanwar added 3 commits October 3, 2017 16:05

Addded EXPTREE in CPP

cbd1add

Addded EXPTREE in CPP

29e4183

Updated JULY.md with EXPTREE in cpp

9b2c098

aashutoshrathi added process/pending_review size/S labels Oct 3, 2017

NishantTanwar mentioned this pull request Oct 3, 2017

EXPTREE (JULY17) [CPP] #194

Open

7 tasks

Added proper spaces in EXPTREE.cpp

3538411

Updated EXPTREE.cpp

00a5807

Monal5031 self-assigned this Oct 3, 2017

Monal5031 added the Hacktoberfest label Oct 3, 2017

Monal5031 added the process/WIP label Oct 3, 2017

Monal5031 requested changes Oct 3, 2017

View reviewed changes

aashutoshrathi changed the title ~~Added EXPTREE in CPP~~ EXPTREE (JULY 17) [CPP] Oct 5, 2017

Updated EXPTREE.cpp

972d4c1

aashutoshrathi removed the process/WIP label Oct 5, 2017

Updated EXPTREE.cpp

2a7e472

Monal5031 reviewed Oct 5, 2017

View reviewed changes

Monal5031 added the process/WIP label Oct 5, 2017

Monal5031 removed the process/pending_review label Oct 5, 2017

NishantTanwar added 2 commits October 11, 2017 03:57

Updated EXPTREE.cpp

e288bf6

Updated EXPTREE.cpp

51409be

aashutoshrathi added the status/inactive label Oct 18, 2017

Monal5031 removed the Hacktoberfest label Oct 30, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EXPTREE (JULY 17) [CPP] #197

EXPTREE (JULY 17) [CPP] #197

NishantTanwar commented Oct 3, 2017 •

edited by aashutoshrathi

aashutoshrathi commented Oct 3, 2017

NishantTanwar commented Oct 3, 2017

NishantTanwar commented Oct 3, 2017 •

edited

Monal5031 commented Oct 3, 2017

Monal5031 left a comment

Monal5031 Oct 3, 2017

NishantTanwar Oct 5, 2017

aashutoshrathi commented Oct 5, 2017

NishantTanwar commented Oct 5, 2017

NishantTanwar commented Oct 5, 2017

aashutoshrathi commented Oct 5, 2017

NishantTanwar commented Oct 5, 2017

aashutoshrathi commented Oct 5, 2017

Monal5031 Oct 5, 2017

Monal5031 Oct 5, 2017

NishantTanwar Oct 10, 2017 •

edited

Monal5031 Oct 10, 2017

Monal5031 Oct 5, 2017

Monal5031 commented Oct 10, 2017

NishantTanwar commented Oct 10, 2017 •

edited

Monal5031 commented Oct 10, 2017

NishantTanwar commented Oct 10, 2017

Monal5031 commented Oct 10, 2017

@@ @@ -17,5 +17,6 @@ @@
               *.class
               *.pyc
               *.html
+              .idea/

EXPTREE (JULY 17) [CPP] #197

Are you sure you want to change the base?

EXPTREE (JULY 17) [CPP] #197

Conversation

NishantTanwar commented Oct 3, 2017 • edited by aashutoshrathi

aashutoshrathi commented Oct 3, 2017

NishantTanwar commented Oct 3, 2017

NishantTanwar commented Oct 3, 2017 • edited

Monal5031 commented Oct 3, 2017

Monal5031 left a comment

Choose a reason for hiding this comment

Monal5031 Oct 3, 2017

Choose a reason for hiding this comment

NishantTanwar Oct 5, 2017

Choose a reason for hiding this comment

aashutoshrathi commented Oct 5, 2017

NishantTanwar commented Oct 5, 2017

NishantTanwar commented Oct 5, 2017

aashutoshrathi commented Oct 5, 2017

NishantTanwar commented Oct 5, 2017

aashutoshrathi commented Oct 5, 2017

Monal5031 Oct 5, 2017

Choose a reason for hiding this comment

Monal5031 Oct 5, 2017

Choose a reason for hiding this comment

NishantTanwar Oct 10, 2017 • edited

Choose a reason for hiding this comment

Monal5031 Oct 10, 2017

Choose a reason for hiding this comment

Monal5031 Oct 5, 2017

Choose a reason for hiding this comment

Monal5031 commented Oct 10, 2017

NishantTanwar commented Oct 10, 2017 • edited

Monal5031 commented Oct 10, 2017

NishantTanwar commented Oct 10, 2017

Monal5031 commented Oct 10, 2017

NishantTanwar commented Oct 3, 2017 •

edited by aashutoshrathi

NishantTanwar commented Oct 3, 2017 •

edited

NishantTanwar Oct 10, 2017 •

edited

NishantTanwar commented Oct 10, 2017 •

edited