Warning "display-fps" deprecated

[low-batt]

System and IINA version:

• macOS 11.4
• IINA 1.2.0

Expected behavior:

mpv does not warn about use of deprecated APIs

Actual behavior:

The following warning is being emitted by mpv:

15:53:17.679 [iina][w] mpv log: [cplayer] warn: Setting the display-fps property is deprecated; set the override-display-fps property instead.

Currently the only effect of using the deprecated property is that it causes mpv to log warning messages as mpv treats this property as an alias for the replacement property override-display-fps. Still it would be good to make mpv happy and change IINA to use the replacement property.

The change to deprecate this property was made in mpv 0.31.0. The mpv document Interface Changes says the following about the change:

   - deprecate --display-fps, introduce --override-display-fps. The display-fps
     property now is unavailable if no VO exists (or the VO did not return a
     display FPS), instead of returning the option value in this case. The
     property will keep existing, but writing to it is deprecated.

The override-display-fps option is documented in the mpv manual here: Options / Video / override-display-fps

I will shortly submit a pull request to switch setting of the display-fps property to instead set override-display-fps.

Steps to reproduce:

Enable logging, open a video, look in the iina.log file for the message shown above.

• [ x] MPV does not have this problem.

This is an issue with how IINA uses mpv.

How often does this happen?

Every time.

[low-batt]

Closing. This was fixed for the 1.3.0 release.