Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seconds to prefetch displays wrong default value #3784

Closed
1 task done
low-batt opened this issue Jun 3, 2022 · 2 comments · Fixed by #3780
Closed
1 task done

Seconds to prefetch displays wrong default value #3784

low-batt opened this issue Jun 3, 2022 · 2 comments · Fixed by #3780

Comments

@low-batt
Copy link
Contributor

low-batt commented Jun 3, 2022

System and IINA version:

  • macOS 12.4
  • IINA 1.3.0

Expected behavior:
Default values displayed in the preferences window match the actual default value provided by IINA code.

Actual behavior:
The preference "Seconds to prefetch" in IINA/Preferences/Network incorrectly indicates the default value is 100 seconds.

This is a regression. The default value was updated from 100 seconds to 36000 seconds without updating the value shown by the preferences window.

PR #3780 from @Mnpn contains a fix for this issue.

Steps to reproduce:

  • Open IINA/Preferences
  • Click on Network
  • In the "Cache" section at the top look for the "Seconds to prefetch" preference
  • Notice that the text after the box containing the value says "Default: 100"
  • MPV does not have this problem.

This is not a mpv problem.

How often does this happen?
Everytime.

@low-batt
Copy link
Contributor Author

low-batt commented Oct 7, 2022

Added label to indicate fix has been merged into develop. Re-opening since this is still a problem in IINA 1.3.0, the latest release. This way any users planning on reporting this problem will hopefully find this open issue and not enter a duplicate.

@low-batt
Copy link
Contributor Author

low-batt commented Nov 7, 2022

Fixed in IINA 1.3.1

@low-batt low-batt closed this as completed Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant