New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeline in Touchbar freezes #4058
Comments
Reproduced. This is a regression. |
This commit will: - Add a new method makeTouchBar to PlayerCore - Change MainWindowController and MiniPlayerWindowController extensions in TouchBarSupport to call the new method - Add a hasTouchBar property to TouchBarSupport - Change MainWindowController.hideUI to not stop the timer that synchronizes the UI if the Mac has a touch bar This corrects a regression added by a change to hideUI to stop the timer when the OSC is hidden in order to save energy. That change failed to take into account that the timer also synchronizes controls in the touch bar on MacBooks that have one.
Any new updates? |
This commit will rename the new hasTouchBar property to needsTouchBar as recommended by review comment.
Thanks for asking. You reminded me there was an outstanding review comment I needed to address. I have just made that change. Now it is waiting for reviewers to approve and merge. |
This commit will rename the new hasTouchBar property to needsTouchBar as recommended by review comment.
This commit will: - Add a new method makeTouchBar to PlayerCore - Change MainWindowController and MiniPlayerWindowController extensions in TouchBarSupport to call the new method - Add a hasTouchBar property to TouchBarSupport - Change MainWindowController.hideUI to not stop the timer that synchronizes the UI if the Mac has a touch bar This corrects a regression added by a change to hideUI to stop the timer when the OSC is hidden in order to save energy. That change failed to take into account that the timer also synchronizes controls in the touch bar on MacBooks that have one.
This commit will: - Add a new method makeTouchBar to PlayerCore - Change MainWindowController and MiniPlayerWindowController extensions in TouchBarSupport to call the new method - Add a hasTouchBar property to TouchBarSupport - Change MainWindowController.hideUI to not stop the timer that synchronizes the UI if the Mac has a touch bar This corrects a regression added by a change to hideUI to stop the timer when the OSC is hidden in order to save energy. That change failed to take into account that the timer also synchronizes controls in the touch bar on MacBooks that have one.
This commit will rename the new hasTouchBar property to needsTouchBar as recommended by review comment.
The fix for this issue has been merged into the IINA Should you wish to confirm the fix is working and do not have the ability to build IINA from the sources in the |
@low-batt I've checked the nightly build, and yeah, the problem has gone. Cool, looking forward for the update! |
@danulqua Sorry about the problem. Thank you for testing the nightly build and confirming the fix. Merging has just started. There are still a good number of fixes in pull requests for critical problems that need to be merged. Stay tuned. |
IINA 1.3.2 contains the fix for this issue. |
System and IINA version:
Expected behavior:
Video progress in Touchbar was dynamic before, timeline was updating every second.
Actual behavior:
Timeline in touchbar is dynamic only either when cursor is visible or overlay, but after they hide - timeline in the touchbar freezes and updates again only when I move the cursor.
mpv log:
Steps to reproduce:
How often does this happen?
Everytime
The text was updated successfully, but these errors were encountered: