Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to hide Quick Panel with On Screen Controller #4071

Closed
karb0f0s opened this issue Nov 12, 2022 · 3 comments · Fixed by #4073
Closed

Unable to hide Quick Panel with On Screen Controller #4071

karb0f0s opened this issue Nov 12, 2022 · 3 comments · Fixed by #4073
Assignees
@low-batt
Labels
bug: regression progress: fixed/implemented

Comments

@karb0f0s
Copy link

System and IINA version:

  • macOS 13.0.1
  • IINA 1.3.1 Build 133

Expected behavior:

Pressing Playlist and Quick Settings buttons should show and hide panel.

Actual behavior:

I have to use shortcuts or menu to hide side panel.
@low-batt low-batt self-assigned this Nov 12, 2022
@low-batt
Copy link
Contributor

Reproduced. Confirmed regression. This must be fixed. Investigating...

In addition to shortcuts and menu you can click in the window outside of the panel to hide it.

low-batt added a commit that referenced this issue Nov 12, 2022
@low-batt
Fix unable to hide Quick Panel with OSC, #4071
02a0a10 
This commit will change the `MainWindowController` methods
`showPlaylistSidebar` and `showSettingsSidebar` to hide or show the
panel when no tab is specified.
@low-batt low-batt mentioned this issue Nov 12, 2022
Merged
2 tasks
@low-batt low-batt linked a pull request Nov 12, 2022 that will close this issue
Fix unable to hide Quick Panel with OSC, #4071 #4073
Merged
2 tasks
uiryuu pushed a commit that referenced this issue Nov 12, 2022
@low-batt @uiryuu
Fix unable to hide Quick Panel with OSC, #4071
d9b5d80 
This commit will change the `MainWindowController` methods
`showPlaylistSidebar` and `showSettingsSidebar` to hide or show the
panel when no tab is specified.
@low-batt
Copy link
Contributor

Fix has been merged into develop.

@low-batt low-batt reopened this Nov 13, 2022
@low-batt
Copy link
Contributor

IINA 1.3.2 contains the fix for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@low-batt low-batt

Labels
bug: regression progress: fixed/implemented
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix unable to hide Quick Panel with OSC, #4071 iina/iina
2 participants
@karb0f0s @low-batt