Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order of filter parameters is random #4262

Closed
1 task done
low-batt opened this issue Mar 11, 2023 · 2 comments · Fixed by #4407
Closed
1 task done

Order of filter parameters is random #4262

low-batt opened this issue Mar 11, 2023 · 2 comments · Fixed by #4407
Assignees
@low-batt
Labels
bug feature: ui/ux progress: fixed/implemented

Comments

@low-batt
Copy link
Contributor

System and IINA version:

  • macOS 13.2.1
  • IINA 1.3.1

Expected behavior:
The order of UI elements representing filter parameters is consistent.

Actual behavior:
The order of UI elements representing filter parameters is random as seen in these two screen shots:
param-order-1

param-order-2

Steps to reproduce:

  • Play a video
  • Click Video filters… under the Video menu
  • In the Video Filters window click +
  • In the pop-up click Blur
  • Note the order of the UI controls representing filter parameters
  • Restart IINA
  • Repeat
  • Do this enough times and the postion of the parameters will change
  • MPV does not have this problem.

This is an IINA issue.

How often does this happen?
You many have to run IINA multiple times to see the parameters change position.
@low-batt low-batt self-assigned this Mar 11, 2023
low-batt added a commit that referenced this issue Mar 11, 2023
@low-batt
Fix order of filter parameters is random, #4262
1b5c099 
This commit will:
- Add a new struct FilterParameters that holds parameters in a
  KeyValuePairs object
- Change FilterPreset to use the new struct to preserve the order of
  parameters specified in the filter definition

This insures the order of the UI controls displayed to the user
representing the filter parameters remains consistent.
@low-batt low-batt mentioned this issue Mar 11, 2023
Closed
2 tasks
@low-batt low-batt linked a pull request Mar 11, 2023 that will close this issue
Fix order of filter parameters is random, #4262 #4263
Closed
2 tasks
low-batt added a commit that referenced this issue May 10, 2023
@low-batt
Fix order of filter parameters is random, #4262
ffadad3 
This commit will:
- Change the FilterPreset property paramOrder to not be optional
- Add setting of paramOrder to all filter presets
- Change NewFilterSheetViewController.showSettings to always use
  paramOrder

This insures the order of the UI controls displayed to the user
representing the filter parameters remains consistent.
@low-batt low-batt mentioned this issue May 10, 2023
Merged
2 tasks
@low-batt low-batt linked a pull request May 10, 2023 that will close this issue
Fix order of filter parameters is random, #4262 #4407
Merged
2 tasks
@low-batt low-batt removed a link to a pull request May 10, 2023
Fix order of filter parameters is random, #4262 #4263
Closed
2 tasks
uiryuu pushed a commit that referenced this issue May 11, 2023
@low-batt
Fix order of filter parameters is random, #4262 (#4407)
60e1f7d 
This commit will:
- Change the FilterPreset property paramOrder to not be optional
- Add setting of paramOrder to all filter presets
- Change NewFilterSheetViewController.showSettings to always use
  paramOrder

This insures the order of the UI controls displayed to the user
representing the filter parameters remains consistent.
@low-batt
Copy link
Contributor Author

The fix for this issue has been merged into the IINA develop branch. GitHub automatically closed the linked issue in reaction to the merge. I am reopening this issue until the fix is available in an official release of IINA so that users intending to report this problem can easily locate this existing report. Once the fix for this issue has been included in an official release this issue will be closed.

Should you wish to confirm the fix is working and do not have the ability to build IINA from the sources in the develop branch, at some point a new unsigned nightly build will be available for download. If you encounter a defect in a nightly build that has not been reported please enter an issue for it and be sure to indicate the problem was found in a nightly build.

The ability to disable this GitHub automatic closing action has been requested by GitHub users (discussions #23476 and #17308 for example), but so far GitHub has not implemented a way to control this behavior.

@low-batt low-batt reopened this May 13, 2023
@low-batt
Copy link
Contributor Author

low-batt commented Jan 2, 2024

This is fixed in the released version of IINA.

@low-batt low-batt closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@low-batt low-batt

Labels
bug feature: ui/ux progress: fixed/implemented
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix order of filter parameters is random, #4262 iina/iina
1 participant
@low-batt