Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom crop view resize issues #4299

Closed
1 task done
yuxiqian opened this issue Mar 27, 2023 · 1 comment · Fixed by #4302
Closed
1 task done

Custom crop view resize issues #4299

yuxiqian opened this issue Mar 27, 2023 · 1 comment · Fixed by #4302
Labels
bug progress: fixed/implemented

Comments

@yuxiqian
Copy link
Contributor

System and IINA version:

  • macOS Ventura 13.3
  • IINA 1.3.1

Start IINA and play a video, open "Quick Settings" panel and select Crop - "Custom...". Drag the right edge over the left boundary and release.

Expected behavior:

Drag the left edge of the box, should be able to resize the box again.

Actual behavior:

Unable to resize by drag the left edge, and its hit-box stays on the right side.

screenshot



Steps to reproduce:

2023-03-27.4.45.10.mov
  • MPV does not have this problem.

How often does this happen?

Every time.
@uiryuu uiryuu added the bug label Mar 27, 2023
@yuxiqian yuxiqian mentioned this issue Mar 28, 2023
Merged
2 tasks
@low-batt low-batt linked a pull request Mar 28, 2023 that will close this issue
Fix: cursor lost when dragging clip view edges #4302
Merged
2 tasks
uiryuu added a commit that referenced this issue Mar 28, 2023
@uiryuu
Standardize crop box upon mouseUp
8178f5b 
Use `minX` and `minY` instead of `origin` when updating cursor rects to
correct the behavior.

Fix #4299
@uiryuu uiryuu mentioned this issue Mar 28, 2023
Closed
2 tasks
@uiryuu uiryuu reopened this Mar 29, 2023
@low-batt
Copy link
Contributor

low-batt commented Jan 2, 2024

This is fixed in the released version of IINA.

@low-batt low-batt closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug progress: fixed/implemented
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: cursor lost when dragging clip view edges yuxiqian/iina
3 participants
@uiryuu @yuxiqian @low-batt