Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar active tab button colors for do not match #4332

Closed
svobs opened this issue Apr 9, 2023 · 1 comment · Fixed by #4378
Closed

Sidebar active tab button colors for do not match #4332

svobs opened this issue Apr 9, 2023 · 1 comment · Fixed by #4378
Assignees
@svobs
Labels
feature: ui/ux progress: fixed/implemented

Comments

@svobs
Copy link
Contributor

svobs commented Apr 9, 2023 •
edited

System and IINA version:

Expected behavior:

The highlight color of the "active" tab in the [Quick] Settings tab group should be the same as the Playlist/Chapters tab group (preferably solid black?)

Actual behavior:

Settings tabs are #000000, but Playlist/Chapters tabs are #61554B.

SCR-20230409-bqzg

SCR-20230409-bqvt

Steps to reproduce:

I highly recommend the amazing app Shottr which is an excellent tool for taking screenshots, analyzing them and annotating them. The shots above are screenshots of it viewing screenshots from IINA, showing the output of its color analyzer.

How often does this happen?

Always
@svobs svobs changed the title Sidebar tab button colors for do not match Sidebar active tab button colors for do not match Apr 9, 2023
@svobs svobs mentioned this issue Apr 22, 2023
Merged
2 tasks
@low-batt low-batt linked a pull request Apr 22, 2023 that will close this issue
Update highlight of sidebar tab buttons so they all match (fixes issue #4332) #4378
Merged
2 tasks
uiryuu pushed a commit that referenced this issue Apr 29, 2023
@svobs
Update highlight of sidebar tab buttons so they all match (fixes issue …
b79ec50 
…#4332) (#4378)

* Update "Playlist" & "Chapters" sidebar tab buttons so that they match the styling of Quick Settings tabs

* Fix missing text hightlight for Playlist tab when starting in Music Mode

* Make Chapters tab bold by default to match other tabs

* Change constant for consistency
@uiryuu uiryuu reopened this Apr 29, 2023
lhc70000 pushed a commit that referenced this issue Apr 29, 2023
@svobs @lhc70000
Update highlight of sidebar tab buttons so they all match (fixes issue …
0b4da2c 
…#4332) (#4378)

* Update "Playlist" & "Chapters" sidebar tab buttons so that they match the styling of Quick Settings tabs

* Fix missing text hightlight for Playlist tab when starting in Music Mode

* Make Chapters tab bold by default to match other tabs

* Change constant for consistency
@low-batt
Copy link
Contributor

low-batt commented Jan 2, 2024

This is fixed in the released version of IINA.

@low-batt low-batt closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svobs svobs

Labels
feature: ui/ux progress: fixed/implemented
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update highlight of sidebar tab buttons so they all match (fixes issue #4332) svobs/iina-advance
3 participants
@svobs @uiryuu @low-batt