Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HDR tone mapping settings #4358

Closed
low-batt opened this issue Apr 17, 2023 · 4 comments · Fixed by #4360
Closed

Add HDR tone mapping settings #4358

low-batt opened this issue Apr 17, 2023 · 4 comments · Fixed by #4360
Assignees
@low-batt
Labels
feature: hdr progress: fixed/implemented type: enhancement

Comments

@low-batt
Copy link
Contributor

What you want IINA to do:
Provide a setting that allows the user to configure the target-peak option along with a way to request that IINA determine the appropriate value for this setting.

Provide a setting that allows the user to configure the mpv tone-mapping algorithm.

Display the pixel format in the inspector window.

Why you think this should be added:
These are improvements to HDR support that have already been implemented by @CarterLi. This issue is for tracking the need to merge this support.

Examples of other projects that have something similar:
These are mpv options.
@low-batt low-batt self-assigned this Apr 17, 2023
@CarterLi
Copy link
Contributor

Good. Call me if you need my help.

low-batt added a commit that referenced this issue Apr 18, 2023
@low-batt @CarterLi
Close add HDR tone mapping settings, #4358
855a8cf 
This commit will:
- Add the new settings enableToneMapping, toneMappingTargetPeak and
  toneMappingAlgorithm
- Update the Audio/Video settings panel to allow the user to control
  these settings
- Update VideoView.refreshEdrMode to support these new settings
- Add the CoreDisplay framework to the Xcode project
- Add support to VideoView.refreshEdrMode to automatically determine
  the target peak setting based on the peak brightness of the display
  using the CoreDisplay framework
- Add reporting of the pixel format to the Inspector window
- Enhance HDR detection in InspectorWindowController.updateInfo
- Correct the path to the PiP framework in the Xcode project

These change provide the ability to mpv's tone mapping when playing HDR
videos.

The main author of these changes is Carter Li. This is a merge of
changes that have been tested in his IINA fork. A few minor changes
were made during the merge.

Co-authored-by: CarterLi <carter.li@eoitek.com>
@low-batt low-batt mentioned this issue Apr 18, 2023
Merged
2 tasks
@low-batt low-batt linked a pull request Apr 18, 2023 that will close this issue
Close add HDR tone mapping settings, #4358 #4360
Merged
2 tasks
@low-batt
Copy link
Contributor Author

Yes, I could use some help. Please look over the PR and see if I messed up anything in the merge, or if you don't like the tweaks I made to the changes.

Sorry it took me so long to post a PR!

low-batt added a commit that referenced this issue Apr 19, 2023
@low-batt @CarterLi
Close add HDR tone mapping settings, #4358
2b0edef 
This commit will:
- Add the new settings enableToneMapping, toneMappingTargetPeak and
  toneMappingAlgorithm
- Update the Audio/Video settings panel to allow the user to control
  these settings
- Update VideoView.refreshEdrMode to support these new settings
- Add the CoreDisplay framework to the Xcode project
- Add support to VideoView.refreshEdrMode to automatically determine
  the target peak setting based on the peak brightness of the display
  using the CoreDisplay framework
- Add reporting of the pixel format to the Inspector window
- Enhance HDR detection in InspectorWindowController.updateInfo
- Correct the path to the PiP framework in the Xcode project

These change provide the ability to mpv's tone mapping when playing HDR
videos.

The main author of these changes is Carter Li. This is a merge of
changes that have been tested in his IINA fork. A few minor changes
were made during the merge.

Co-authored-by: CarterLi <carter.li@eoitek.com>
low-batt added a commit that referenced this issue Apr 19, 2023
@low-batt @CarterLi
Close add HDR tone mapping settings, #4358
a544038 
This commit will:
- Add the new settings enableToneMapping, toneMappingTargetPeak and
  toneMappingAlgorithm
- Update the Audio/Video settings panel to allow the user to control
  these settings
- Add help buttons that link to Wikipedia and the appropriate sections
  of the mpv manual
- Update VideoView.refreshEdrMode to support these new settings
- Add the CoreDisplay framework to the Xcode project
- Add support to VideoView.refreshEdrMode to automatically determine
  the target peak setting based on the peak brightness of the display
  using the CoreDisplay framework
- Add reporting of the pixel format to the Inspector window
- Enhance HDR detection in InspectorWindowController.updateInfo
- Correct the path to the PiP framework in the Xcode project

These change provide the ability to mpv's tone mapping when playing HDR
videos.

The main author of these changes is Carter Li. This is a merge of
changes that have been tested in his IINA fork. A few minor changes
were made during the merge.

Co-authored-by: CarterLi <carter.li@eoitek.com>
low-batt added a commit that referenced this issue Apr 23, 2023
@low-batt @CarterLi
Close add HDR tone mapping settings, #4358
ad0dbca 
This commit will:
- Add the new settings enableToneMapping, toneMappingTargetPeak and
  toneMappingAlgorithm
- Update the Audio/Video settings panel to allow the user to control
  these settings
- Update VideoView.refreshEdrMode to support these new settings
- Add the CoreDisplay framework to the Xcode project
- Add support to VideoView.refreshEdrMode to automatically determine
  the target peak setting based on the peak brightness of the display
  using the CoreDisplay framework
- Add reporting of the pixel format to the Inspector window
- Enhance HDR detection in InspectorWindowController.updateInfo
- Correct the path to the PiP framework in the Xcode project

These change provide the ability to mpv's tone mapping when playing HDR
videos.

The main author of these changes is Carter Li. This is a merge of
changes that have been tested in his IINA fork. A few minor changes
were made during the merge.

Co-authored-by: CarterLi <carter.li@eoitek.com>
uiryuu added a commit that referenced this issue Apr 23, 2023
@low-batt @CarterLi @uiryuu
Close add HDR tone mapping settings, #4358 (#4360)
52708e7 
* Close add HDR tone mapping settings, #4358

This commit will:
- Add the new settings enableToneMapping, toneMappingTargetPeak and
  toneMappingAlgorithm
- Update the Audio/Video settings panel to allow the user to control
  these settings
- Update VideoView.refreshEdrMode to support these new settings
- Add the CoreDisplay framework to the Xcode project
- Add support to VideoView.refreshEdrMode to automatically determine
  the target peak setting based on the peak brightness of the display
  using the CoreDisplay framework
- Add reporting of the pixel format to the Inspector window
- Enhance HDR detection in InspectorWindowController.updateInfo
- Correct the path to the PiP framework in the Xcode project

These change provide the ability to mpv's tone mapping when playing HDR
videos.

The main author of these changes is Carter Li. This is a merge of
changes that have been tested in his IINA fork. A few minor changes
were made during the merge.

Co-authored-by: CarterLi <carter.li@eoitek.com>

* Close add HDR tone mapping settings, #4358

This commit will:
- Add the new settings enableToneMapping, toneMappingTargetPeak and
  toneMappingAlgorithm
- Update the Audio/Video settings panel to allow the user to control
  these settings
- Add help buttons that link to Wikipedia and the appropriate sections
  of the mpv manual
- Update VideoView.refreshEdrMode to support these new settings
- Add the CoreDisplay framework to the Xcode project
- Add support to VideoView.refreshEdrMode to automatically determine
  the target peak setting based on the peak brightness of the display
  using the CoreDisplay framework
- Add reporting of the pixel format to the Inspector window
- Enhance HDR detection in InspectorWindowController.updateInfo
- Correct the path to the PiP framework in the Xcode project

These change provide the ability to mpv's tone mapping when playing HDR
videos.

The main author of these changes is Carter Li. This is a merge of
changes that have been tested in his IINA fork. A few minor changes
were made during the merge.

Co-authored-by: CarterLi <carter.li@eoitek.com>

* Close add HDR tone mapping settings, #4358

This commit will:
- Add the new settings enableToneMapping, toneMappingTargetPeak and
  toneMappingAlgorithm
- Update the Audio/Video settings panel to allow the user to control
  these settings
- Update VideoView.refreshEdrMode to support these new settings
- Add the CoreDisplay framework to the Xcode project
- Add support to VideoView.refreshEdrMode to automatically determine
  the target peak setting based on the peak brightness of the display
  using the CoreDisplay framework
- Add reporting of the pixel format to the Inspector window
- Enhance HDR detection in InspectorWindowController.updateInfo
- Correct the path to the PiP framework in the Xcode project

These change provide the ability to mpv's tone mapping when playing HDR
videos.

The main author of these changes is Carter Li. This is a merge of
changes that have been tested in his IINA fork. A few minor changes
were made during the merge.

Co-authored-by: CarterLi <carter.li@eoitek.com>

* Add a period

---------

Co-authored-by: CarterLi <carter.li@eoitek.com>
Co-authored-by: Yuze Jiang <i@uiryuu.moe>
@low-batt
Copy link
Contributor Author

The changes to add the enhancement described by this issue have been merged into the IINA develop branch. GitHub automatically closed the linked issue in reaction to the merge. I am reopening this issue until the this enhancement is available in an official release of IINA.

@low-batt low-batt reopened this Apr 24, 2023
@low-batt
Copy link
Contributor Author

IINA 1.3.2 contains this enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@low-batt low-batt

Labels
feature: hdr progress: fixed/implemented type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close add HDR tone mapping settings, #4358 iina/iina
2 participants
@CarterLi @low-batt