Black out window triggers makeKeyWindow warning

[low-batt]

System and IINA version:

• macOS 13.6.1
• IINA 1.3.3

Expected behavior:
When the IINA setting Black out other monitors while in full screen enabled no warnings are emitted.

Actual behavior:
When runing IINA under Xcode with setting Black out other monitors while in full screen enabled and using multiple monitors the following warning is seen the Xcode console after entering full screen mode:

Warning: -[NSWindow makeKeyWindow] called on NSWindow 0x7fe08908a850 which returned NO from -[NSWindow canBecomeKeyWindow].

Steps to reproduce:

• Start IINA runing under Xcode

• Click on Settings… under the IINA menu

• The settings panel appears

• In the Behavior section look for the Black out other monitors while in full screen setting

• Enable that setting

• Start playing a video

• Click on the menu item Enter Full Screen under the Video menu

• Look for the warning in the Xcode console

• MPV does not have this problem.

How often does this happen?
Most of the time.

[low-batt]

Analysis

The warning is triggered by the following call to makeKeyAndOrderFront:

iina/iina/MainWindowController.swift

Line 2577 in aa5a415

blackWindow.makeKeyAndOrderFront(nil)

From the documentation for canBecomeKey:

The value of this property is true if the window can become the key window, otherwise, false.

Attempts to make the window the key window are abandoned if the value of this property is false. The value of this property is true if the window has a title bar or a resize bar, or false otherwise.

The window used to black out a monitor does not meet these requirements and therefore can not become a key window. Debugging confirmed canBecomeKey is false for the black out window which explains why AppKit is emitting the warning.

Fixing

The commit in the pull request changes the method blackOutOtherMonitors in the class MainWindowController to call orderFront instead of makeKeyAndOrderFront.