New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subtitles FPS label on found subs list #4763
Comments
This commit will: - Change the Subtitle struct in OpenSubClient to always include the fps property - Change the getDescription method in OpenSub to include the fps in the subtitle chooser if Open Subtitles provided a value
@browser-bug Thanks for entering this issue. As the spacing is rather tight I rounded the fps up. Do you think that is sufficient or is more precision required? |
@low-batt |
It is looking like our next release will be focused on fixing regressions with a feature release to follow. To get this in now for the next release I wanted to minimize the changes required. That is why I wanted to avoid trying to expand the size of this UI. I do agree that more precision is desirable. The current code for downloading subtitles is considered legacy code. The plan is to replace the existing code with a plugin implementation. Hopefully that work will include enhancements to the user interface. On using an icon, I did look around for an icon. I found a lot of them. They were associated with online gaming. I didn't find anything I thought people would recognize as frames per second. Are you aware of something? For this change I would not have used an icon as that would require a lot of changes as the UI is not structured for that. What looks like icons in the UI is actually characters: ⬇︎ ★ I will check with the other developers to see if they think it is ok to squeeze in a couple more characters. |
The fix for this issue has been merged into the IINA |
I think a more compact date & time formatting would save some space for the other items. I doubt anyone will ever want to know the exact seconds of the upload date. |
also related to this menu, I'd like to bring up #4142. having the subtitle file name multilined or marquee-like would be great. |
What you want IINA to do:
When displaying the subtitles found (using Opensubtitles.com, etc.) show also the FPS of the subs if available:
What IINA does currently:
It shows the subs list without this information. In particular it currently only shows:
Why you think this should be added:
This would benefit the choice of the sub since it depends on the video source FPS. It is quite common that multiple subtitles are found but I cannot choose the correct one and therefore find myself going to the site for a double check (which makes the in-player download feature almost useless).
The text was updated successfully, but these errors were encountered: