Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[it] update italian translation for 1.0.0 #2066

Merged
merged 2 commits into from Nov 5, 2018
Merged

[it] update italian translation for 1.0.0 #2066

merged 2 commits into from Nov 5, 2018

Conversation

cgand
Copy link
Contributor

@cgand cgand commented Nov 5, 2018

Update italian localizations for 1.0 Release #2054

@cgand
[it] updat italian translation for 1.0.0
b0b159b 
Update italian localizations for 1.0 Release #2054
@uiryuu
Copy link
Member

uiryuu commented Nov 5, 2018 •
edited

Thanks for you work!
There are some issues in this PR:

  • SubSelectWindowController.strings in iina/it.lproj is not used, please delete it.
  • MiniPlayerWindowController.strings is missing.
  • In Localizable.strings, alert.config.cannot_create has a placeholder %@, which should also appear in the corresponding translation. Please fix it.

@cgand
Copy link
Contributor Author

cgand commented Nov 5, 2018

All strings should be fixed. Not sure if a \n should be before %@ in alert.config.cannot_create

@uiryuu uiryuu merged commit b67c9b2 into iina:release/1.0.0 Nov 5, 2018
@uiryuu
Copy link
Member

uiryuu commented Nov 5, 2018

Yes, you are doing right. Thanks!

@cgand cgand deleted the release/1.0.0 branch November 5, 2018 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cgand @uiryuu