Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved zh-Hant translation #2525

Merged
merged 1 commit into from Jul 22, 2019
Merged

Improved zh-Hant translation #2525

merged 1 commit into from Jul 22, 2019

Conversation

ralphchung
Copy link
Contributor

  • This change has been discussed with the author.
  • It implements / fixes issue #.

Description:
This commit did these things:

  • Filled in the missing translation in FilterPresets.strings
  • Rephrased some of this translation in order to make it consistent with the translation in macOS. This was done by referring to the glossary from here provided by Apple.

This localization has been tested by 'IINA Translation Utility'. Also, I have built and run this app on my machine successfully.

I am welcome to discuss anything about this PR. Thank you.

uiryuu
uiryuu approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@uiryuu uiryuu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for such a detailed overhaul for zh-Hant localization. LGTM. I'll test on my machine shortly and merge it.

@uiryuu uiryuu merged commit 37488ef into iina:develop Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uiryuu uiryuu uiryuu approved these changes

Assignees
No one assigned
Labels
type: localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ralphchung @uiryuu