Fix infinite loops #2531
Merged
Fix infinite loops #2531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uiryuu
requested changes
Jul 31, 2019
lhc70000
approved these changes
Jan 13, 2020
revolter
pushed a commit
to revolter/iina
that referenced
this pull request
Apr 25, 2020
* fix infinite loop happening on identical file names. * fix whitespaces * better style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This commit intends to fix a kind of infinite loops:
If there are files like:
/-test.mp4
|-dir0/a.sub
|-dir1/a.sub
|-dir2/a.sub
|-dir3/a.sub
The tryGroupFiles method would find it self infinitely looping i++ when dealing with these "a.sub" files. And the user may find iina using 100% CPU at this time.