Fix currently open filenames not syncing, #3159 #3435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
low-batt
changed the title
Change MainWindowController.windowWillOpen to set the window's title to "Window", the title a NSWindow has by default. If the title is not reset when a window is reused then the wrong title will be displayed in the "Window" menu.
This problem is due to a defect in AppKit that has been fixed in macOS Monterey. The commit changes the window controller to apply a workaround of reseting the window's title in earlier versions of macOS. If the title is not reset when a window is reused then the wrong title will be displayed in the "Window" menu. The commit will: - Change MainWindowController.windowWillOpen to set the window's title to "Window", the title a NSWindow has by default
lhc70000
pushed a commit
that referenced
this pull request
Apr 24, 2022
* Fix currently open filenames not syncing, #3159 Change MainWindowController.windowWillOpen to set the window's title to "Window", the title a NSWindow has by default. If the title is not reset when a window is reused then the wrong title will be displayed in the "Window" menu. * Fix currently open filenames not syncing, #3159 This problem is due to a defect in AppKit that has been fixed in macOS Monterey. The commit changes the window controller to apply a workaround of reseting the window's title in earlier versions of macOS. If the title is not reset when a window is reused then the wrong title will be displayed in the "Window" menu. The commit will: - Change MainWindowController.windowWillOpen to set the window's title to "Window", the title a NSWindow has by default
This was referenced Apr 30, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change MainWindowController.windowWillOpen to set the window's title to
"Window", the title a NSWindow has by default. If the title is not reset
when a window is reused then the wrong title will be displayed in the
"Window" menu.
Description: