Fix incorrect playlist item moved to trash (issue #4061) #4118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svobs
changed the title
|
Please split your commits into multiple PRs next time, thanks! |
svobs
force-pushed
the
pr-playlist-move-to-trash-fix
branch
from
e2b42cb
to
f2896b2
Compare
…ylist context menu
svobs
force-pushed
the
pr-playlist-move-to-trash-fix
branch
from
f2896b2
to
0d9d153
Compare
|
Updated the code to remove everything except the bug fix |
svobs
changed the title
|
Hopefully this can make it into the next release? This is a serious bug because it can result in unexpected loss of user data, and this fix is not too complicated. Attn @uiryuu |
|
Thanks for reminding. Rest assured, this will definitely go into the next release. |
|
Thanks! |
@uiryuu Is there an ETA for the new release? This bug is bad enough to warrant a quick patch release on its own. Thanks. |
|
@jiripospisil We are building the dependencies for the new release. Should be soon, but no eta still. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In Playlist context menu,
Move to Trashwas removing the item from the playlist before getting the filename from it, which resulted in either the incorrect file being sent to trash, or IINA crashing. Changed so that it first attempts to move each file to the trash, and only removes from the playlist at the end, and only removes the ones were successfully trashed.