New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playback History window: modernize look & improve window functionality #4257
Conversation
Glad you are working on this. I tested macOS Catalina and changes look good there. If you want to improve it some more there are some other issues with this window. This screen shot shows 2 issues. Note the "|" after the If I enlarge the window the extra column is easy to see: Grouping by |
b6dedc3
to
5722605
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested under macOS Ventura 13.2.1 and macOS Catalina 10.15.7. Significant improvements to the history window. Looks good to me.
@low-batt I see you noticed my push, thanks! I didn't have time to do a writeup. But I still wanted to add a few extra notes for clarity. I played with the sizing of the table columns quite a bit, but I was unable to come up with an ideal solution which prevents the wasted space in the right gutter. It seems to be a limitation of its (very, very old) design. You may have noticed that shrinking the window manually to close that gap and then expanding it again seems to snap the rightmost column to the right side of the window as desired. That seems to be a modern addition. But Apple didn't provide any kind of handle for it, so getting that to happen programmatically is extremely difficult. I did find this old post but the comments were not helpful. After adding up the column sizes and the intercell spacing, comparing the sum to the width of the table still left...12.5 pts...still unaccounted for. Getting the calculation off by even a pixel would create a horizontal scroll, so I don't think it's wise to try to fudge it. I made a separate attempt to try to get the widths of the So, as noted in the commit, I added a larger min-width constraint when grouping by OK that's enough rambling... the other comments in the commit should be self-explanatory. |
@svobs |
@uiryuu: see new commit |
5663d34
to
e083d6f
Compare
Since we are now using a fixed sized font, should the format of dates and times in |
Huh. I didn't actually notice that my previous fix didn't work and the font wasn't actually fixed width. It looked like it lined up and it didn't show the actual font being used... New commit uses Menlo explicitly. Not the prettiest font, but I don't think there's a prettier built-in alternative. |
…mproved layout constraints & column sizing, + remembers window size & positions + column sizes & positions
…y" selection. Disable animation of Progress column in History table (scrolling is much faster now). Disable ability to reorder History table columns due to problem restoring state.
8a060f2
to
f927e14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please consider changing the search text field to rounded style
iina/HistoryWindowController.swift
Outdated
@@ -55,6 +59,7 @@ class HistoryWindowController: NSWindowController, NSOutlineViewDelegate, NSOutl | |||
|
|||
override func windowDidLoad() { | |||
super.windowDidLoad() | |||
self.windowFrameAutosaveName = "PlaybackHistoryWindow" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please set the autosave name in the xib editor as we did before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please consider changing the search text field to rounded style
So, search boxes are rounded, but all other text boxes are square?
Made new commit with requested changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, search boxes are rounded, but all other text boxes are square?
But all search text fields are rounded, like the one in the key binding pref.
Before:
After:
Description:
Submitting this in case there is interest.
File
column now expands/shrinks when the window size changes.Played at
column so that its title is not cut off.Folder
, to help fit the longer content.