Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand IINA screenshot functionality to screenshot flags #4853

Merged
merged 2 commits into from
May 26, 2024
Merged

Expand IINA screenshot functionality to screenshot flags #4853

merged 2 commits into from
May 26, 2024

Commits on Mar 19, 2024

  1. Expand IINA screenshot functionality to screenshot flags 

    Summary:
• Applies IINA screenshot OSD & other enhancements to screenshot
  commands which have flags (except for "each-frame" flag)
• Expand functionality of PlayerCore.screenshot() to handle screenshot
  command from a key binding
• Add logic so that if any flags are found in the screenshot command,
  they will be used
• Else if no flags are specified, then the value for pref key
  "screenshotIncludeSubtitle" will be used to determine the flags
    @svobs
    svobs committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    1c72e06 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Update based on feedback + add logging

    @svobs
    svobs committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    329726c View commit details
    Browse the repository at this point in the history