Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RTL language causes OSC to malfunction, #4878 #4879

Merged
merged 1 commit into from
May 25, 2024
Merged

Fix RTL language causes OSC to malfunction, #4878 #4879

merged 1 commit into from
May 25, 2024

Commits on Apr 20, 2024

  1. Fix RTL language causes OSC to malfunction, #4878

    This commit will:
    - Add initializers to TimeLabelOverflowedStackView,
      TimeLabelOverflowedView and TouchBarPlaySliderCell that set
      userInterfaceLayoutDirection to be leftToRight
    - Change MainWindowController.windowDidLoad to set the
      userInterfaceLayoutDirection property of fragControlView and
      oscFloatingTopView to be leftToRight
    - Change constraints from leading/trailing to left/right for several OSC
      components to prevent them from moving when a RTL language is used
    - Change MainWindowController methods mouseDown and mouseDragged to take
      into account the userInterfaceLayoutDirection setting during playlist
      resizing
    - Change ControlBarView.mouseDragged to take into account the
      userInterfaceLayoutDirection setting when repositioning the floating
      OSC
    - Rename the play property in the Constants struct to be
      blackRightPointingTriangle
    - Add a blackLeftPointingTriangle property to the Constants struct
    - Change PlaylistViewController.tableView to use a right or left arrow
      based on the userInterfaceLayoutDirection setting
    - Change the language-direction of the pip and volume related icons and
      the playlist icon from Fixed to Left to Right, Mirrors
    
    This adjusts IINA's behavior to match Apple's guidance that video
    controls and timeline indicators should not flip in a right-to-left
    language. Other controls, such as the volume control and the pip and
    playlist buttons are flipped for RTL languages.
    
    This also corrects problems dragging the floating OSC and resizing the
    playlist when a right to left language is configured.
    low-batt committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    b6eec19 View commit details
    Browse the repository at this point in the history