New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve always on top behavior #580

Merged

lhc70000 merged 1 commit into develop from improve-always-float-on-top

Apr 17, 2017

Member

lhc70000 commented Apr 17, 2017

This change has been discussed with the author.
It implements / fixes issue Always float on top while playing seems not working|播放时置顶无效 #533, set playing video on top window, but when paused, it's still on top window #234, The video plays at the top, not at all times #133.

Description:

Reimplement of #550.


          improve always on top behavior

512d848

lhc70000 merged commit ffab78d into develop

lhc70000 deleted the improve-always-float-on-top branch

April 17, 2017 22:22

saagarjha reviewed

View reviewed changes

iina/MainWindowController.swift

                       }
                     }
+                  case PK.alwaysFloatOnTop:
+                    if let newValue = change[NSKeyValueChangeKey.newKey] as? Bool {

Member

saagarjha Apr 17, 2017

(newValue = change[NSKeyValueChangeKey.newKey] as? Bool).flatMap { 
	setWindowFloatingOnTop($0)
}

uiryuu mentioned this pull request

set playing video on top window, but when paused, it's still on top window #234

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment