Improvements #78
Merged
Improvements #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
uiryuu
commented
Jan 7, 2017
•
uiryuu
commented
- Handle error code when adding unsupported subtitles and audios.
- Enable dragging subtitles in VideoView.
- Change the original behavior in PlaylistDragDestView when dragging. It will not add non-video files into playlist now.
Prevent fatal error when subtitles and audios are not supported.
Prevent fatal error when subtitles and audios are not supported.
Prevent fatal error when subtitles and audios are not supported.
Prevent fatal error when subtitles and audios are not supported.
lhc70000
requested changes
Jan 7, 2017
|
|
||
| override func performDragOperation(_ sender: NSDraggingInfo) -> Bool { | ||
| let board = sender.draggingPasteboard() | ||
| let fileURL: NSURL? = NSURL(from: board) |
There was a problem hiding this comment.
This solution only supports single file.
Please refer to PlaylistDragDestView.swift.
| override func performDragOperation(_ sender: NSDraggingInfo) -> Bool { | ||
| let board = sender.draggingPasteboard() | ||
| let fileURL: NSURL? = NSURL(from: board) | ||
| playerCore.loadExternalSubFile(fileURL as! URL) |
There was a problem hiding this comment.
Maybe need to check whether it's a subtitle file, if not, load the dragged file (as video).
There was a problem hiding this comment.
Do you have a list of the support format of subtitles, audio tracks and videos? I think it helps to handle.
| func loadExternalAudioFile(_ url: URL) { | ||
| mpvController.command(.audioAdd, args: [url.path]) | ||
| mpvController.command(.audioAdd, args: [url.path], checkError: false, returnValueCallback: failedLoadExternalAudioFile) |
There was a problem hiding this comment.
I prefer using a block here. What do you think?
| func loadExternalSubFile(_ url: URL) { | ||
| mpvController.command(.subAdd, args: [url.path]) | ||
| mpvController.command(.subAdd, args: [url.path], checkError: false, returnValueCallback: failedLoadExternalSubFile) |
Change the original behavior in PlaylistDragDestView when dragging. It will not add non-video files into playlist now.
VideoView and playlist now accept every file except subtitles.
lhc70000
approved these changes
Jan 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.