Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in _send, should Runtime.evaluate take "returnByValue": False? #3

Closed
cjrh opened this issue Apr 24, 2016 · 1 comment
Closed

in _send, should Runtime.evaluate take "returnByValue": False? #3

cjrh opened this issue Apr 24, 2016 · 1 comment

Comments

@cjrh
Copy link

cjrh commented Apr 24, 2016

This is perhaps more of a question than an issue, but in my project, I need to add "returnByValue": False, at around line 72 in __init__.py:

(note, I'm adding line breaks only to make it easier to read)

def evaluate(self, javascript):
    """
    Evaluate JavaScript on the page
    """
    return self._send(
        {"method": "Runtime.evaluate", 
         "params": {"expression": javascript, 
            "returnByValue": False}})        # <---- This bit

Without this, I don't get back the full string contents of returned data, e.g. the results of Array maps and so on. I'm happy to make a PR to make this a setting (e.g. an extra param on evaluate, with default set to True), but just wanted to find out your thoughts?

@cjrh
Copy link
Author

cjrh commented Apr 24, 2016

No, that wasn't it. There's something else going on. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant