[REPEKA-140] Fail tests when there are warnings

sebastianbergmann/phpunit#2246

Change-Id: I8a61ed18fcbf847f65ae0f56969e477a8760e8a9

package.json

@@ -39,9 +39,9 @@
     "test": "npm run -s test:backend && npm run -s test:admin",
     "test:admin": "cd src/AdminPanel && npm test -s",
     "test:backend": "npm run -s test:backend:unit && npm run -s test:backend:integration",
-    "test:backend:unit": "sh -c \"vendor/bin/phpunit -c scripts/phpunit.xml\"",
-    "test:backend:integration": "sh -c \"vendor/bin/phpunit -c scripts/phpunit_integration.xml\"",
-    "test:backend:junit": "sh -c \"vendor/bin/phpunit -c scripts/phpunit.xml --testdox --log-junit var/reports/tests/phpunit.xml --coverage-clover var/reports/coverage/phpunit.xml && vendor/bin/phpunit -c scripts/phpunit_integration.xml --testdox --log-junit var/reports/tests/phpunit_integration.xml\"",
+    "test:backend:unit": "sh -c \"vendor/bin/phpunit -c scripts --fail-on-warning\"",
+    "test:backend:integration": "sh -c \"vendor/bin/phpunit -c scripts/phpunit_integration.xml --fail-on-warning\"",
+    "test:backend:junit": "sh -c \"vendor/bin/phpunit -c scripts --fail-on-warning --testdox --log-junit var/reports/tests/phpunit.xml --coverage-clover var/reports/coverage/phpunit.xml && vendor/bin/phpunit -c scripts/phpunit_integration.xml --fail-on-warning --testdox --log-junit var/reports/tests/phpunit_integration.xml\"",
     "test:junit": "rm -f var/reports/tests/*.xml var/reports/coverage/*.xml && npm run -s test:backend:junit && cd src/AdminPanel && npm run -s test:junit",
     "watch": "npm run -s clean && cd src/AdminPanel && npm run -s watch"
   }

scripts/phpunit.xml

@@ -5,6 +5,10 @@
          xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/4.8/phpunit.xsd"
          backupGlobals="false"
          colors="true"
+         convertErrorsToExceptions="true"
+         convertNoticesToExceptions="true"
+         convertWarningsToExceptions="true"
+         strict="true"
          bootstrap="../app/autoload.php">
     <php>
         <ini name="error_reporting" value="-1"/>

scripts/phpunit_integration.xml

@@ -5,6 +5,10 @@
          xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/4.8/phpunit.xsd"
          backupGlobals="false"
          colors="true"
+         convertErrorsToExceptions="true"
+         convertNoticesToExceptions="true"
+         convertWarningsToExceptions="true"
+         strict="true"
          bootstrap="../app/integration_tests_bootstrapper.php">
     <php>
         <ini name="error_reporting" value="-1"/>

src/Repeka/Tests/Domain/Entity/ResourceWorkflowTest.php

@@ -86,7 +86,8 @@ public function testApplyingTransition() {
 
     public function testMovingToState() {
         $this->workflow->setWorkflowStrategy($this->workflowStrategy);
-        $this->workflowStrategy->expects($this->once())->method('move')->with($this->resource, ['thestate'])->willReturnArgument(0);
+        $this->workflowStrategy->expects($this->once())->method('setCurrentPlaces')
+            ->with($this->resource, ['thestate'])->willReturnArgument(0);
         $this->workflow->setCurrentPlaces($this->resource, ['thestate']);
     }
 

src/Repeka/Tests/Domain/UseCase/ResourceWorkflow/ResourceWorkflowSimulateCommandHandlerTest.php

@@ -27,7 +27,7 @@ public function testHandlingSimpleWorkflow() {
             [new ResourceWorkflowTransition([], [], [], 'transition')]
         );
         $this->workflowStrategy->expects($this->never())->method('apply');
-        $this->workflowStrategy->expects($this->once())->method('move')->with($this->isInstanceOf(ResourceEntity::class), []);
+        $this->workflowStrategy->expects($this->once())->method('setCurrentPlaces')->with($this->isInstanceOf(ResourceEntity::class), []);
         $result = $this->handler->handle($command);
         $this->assertCount(2, $result);
         $this->assertCount(1, $result['places']);
@@ -37,7 +37,8 @@ public function testHandlingSimpleWorkflow() {
     public function testMovingToDesiredCurrentPlace() {
         $command = new ResourceWorkflowSimulateCommand([], [], ['current']);
         $this->workflowStrategy->expects($this->never())->method('apply');
-        $this->workflowStrategy->expects($this->once())->method('move')->with($this->isInstanceOf(ResourceEntity::class), ['current']);
+        $this->workflowStrategy->expects($this->once())->method('setCurrentPlaces')
+            ->with($this->isInstanceOf(ResourceEntity::class), ['current']);
         $this->handler->handle($command);
     }