Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Uniques by Visit does not work on some portals #1143

Open
SebastianHelm opened this issue Oct 28, 2016 · 0 comments
Open

Sort Uniques by Visit does not work on some portals #1143

SebastianHelm opened this issue Oct 28, 2016 · 0 comments

Comments

@SebastianHelm
Copy link

This occurs when using the Uniques add-on. Some portals, such as https://www.ingress.com/intel?ll=50.182744,8.486106&z=17&pll=50.182744,8.486106, don't get sorted by the Visit column.

Repro:

  1. Select a view that includes https://www.ingress.com/intel?ll=50.182744,8.486106&z=17&pll=50.182744,8.486106 and a few portals around it. E.g. this view: https://www.ingress.com/intel?ll=50.182744,8.486106&z=17&pll=50.182744,8.486106.
  2. Select Portals list.
  3. Click on the "Visit" heading.

Expected:

All portals should be sorted by their visit (and capture) status.

Observed:

Portals are sorted in the following sequence:

  1. Not visited
  2. Visited only
  3. Visited+Captured
  4. Again some portals that have not been visited

Expected:

Unvisited portals to be sorted together.

Fix:

In uniques.user.js, at the end of function uniqueValue(guid), add the following line:
return 0;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants