-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails to delete portals by bounds #1149
Comments
Can you please give some more information? What particular error do you see? What are you trying to do at the time? What actually fails, and what effect does it have? |
accessed 'portals'. say i was at zoom 19 with 3 visible portals. (perhaps it stores those for big fields and/or long links in the (very major) area?) so, no "particular error" |
Ah, so you mean that the I can see how it would be useful to have a "get portals within viewport" function, so I will make this a feature request. |
We used to get shard portals, target portals, etc. var bounds=map.getBounds(), portalsInBounds={}; (I actually use an array of guids and then access 'portals'.) Can I get portals details of a portal that is NOT in view directly into a variable? Thanks Dave! |
I can understand why everyone is looking here. The portals, links, and fields collections appear to be our biggest bottleneck. However, there's more going on here than what appears. The real bottleneck is how we are writing to localstorage. Since localstorage values are written as a giant string, it rewrites the whole thing over and over again every time we update the collection. Simply awful code. We need to move this to indexedDB, as such I'm going to branch and implement https://github.com/jakearchibald/idb to see how much it will help. |
how can i get portal details into a js var without the need to show them on the map? |
@iAmOren Some, if not most, Ingress players would say that to stay close to the spirit of the game, you should click on the portal to get the portal details. As I understand, automating the fetching of the portal details is very risky due to the potential of putting load onto the Ingress servers that would exceed a typical human interaction. I wouldn't want you to get banned or to have IITC be put at risk. I recommend that you get the portal details via Lastly, I see the conversation has drifted from the original subject line. I recommend this issue be closed. |
Well, there used to be a plugin "show more portals". |
@iAmOren I did some testing. You are indeed correct that there is a plugin out there causing the portals out of bounds to be recreated. I haven't found the specific cause yet, but it's not caused by anything in this project. I'll contact you privately when I find the culprit, or please do the same for me if you find it first. In my testing, it appears that something is hooking portal removed and putting it back. |
The missions plugin should be reviewed. It's a possible source of the issue, while not doing the adding directly. It's attempting to override the deletePortalEntity, and while it does appear that it attempts to replace it, I can already tell there are going to be certain situations where this isn't going to work, and the delete behavior will be lost. I'll update more when I've tracked down the mentioned cases. |
FesterCluck, missions are not for me, so, if there is a plugin for them, I do not have it installed... |
This isn't a bug in IITC |
Thank you all for your valuable input! |
window.Render.prototype.startRenderPass ->
window.Render.prototype.clearPortalsOutsideBounds
perhaps links and fields as well.
The text was updated successfully, but these errors were encountered: