Random matrix sampling on the GPU #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgawron
requested changes
Aug 25, 2019
curandommatrices/src/circular.jl
Outdated
| function _qr_fix!(z::CuMatrix) | ||
| q, r = CuArrays.qr!(z) | ||
| ph = diag(r) | ||
| len = min(length(ph), 1024) |
There was a problem hiding this comment.
Why the magic number 1024 ? Explain it or at least point to some information.
There was a problem hiding this comment.
This is just an ugly hack as warpsize() results in a segfault.
pgawron
approved these changes
Aug 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should merge this and state clearly, in big bold red letters in the readme that this is highly experimental and we would appreciate any feedback.
As there are probably some mistakes I think people should have access to this iteration of GPU support and state their comments