feat: add support for disabling tracking via localStorage #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supermar1010
changed the title
supermar1010
changed the title
|
Thank you, Mario. |
|
LGTM 👍. |
supermar1010
commented
May 20, 2024
| location: { hostname }, | ||
| } = window; | ||
| const hostname = window.location.hostname; | ||
| const storage = window.localStorage; |
There was a problem hiding this comment.
I'm honestly not sure what the difference in access between window.localStorage and just using localStorage is, but I also can't find any information on the internet about this, so if this also works, I don't have an oponion :D
|
Looks good to me (just see the comment I'm not sure about the difference between the localStorage call via window and without, but if it works it's fine for me!) |
ijkml
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for disabling tracking via localStorage(umami.disabled=1) (#103)