Remove ember-css-modules #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
force-pushed
the
remove-ember-css-modules
branch
4 times, most recently
from
6506c12
to
1e1e1e6
Compare
ijlee2
force-pushed
the
remove-ember-css-modules
branch
from
1be2016
to
aa2dc5e
Compare
ijlee2
force-pushed
the
remove-ember-css-modules
branch
from
aa2dc5e
to
2a2b2fd
Compare
* fix(docs): only process own styles as local * bugfix: Used includes (weakened assertion) to avoid false negatives --------- Co-authored-by: ijlee2 <ijlee2@users.noreply.github.com>
ijlee2
commented
Apr 10, 2023
Comment on lines
+8
to
+13
| { | ||
| files: '*.css.d.ts', | ||
| options: { | ||
| quoteProps: 'preserve', | ||
| }, | ||
| }, |
There was a problem hiding this comment.
ijlee2
commented
Apr 10, 2023
Comment on lines
+46
to
+64
| module: { | ||
| rules: [ | ||
| { | ||
| exclude: /node_modules/, | ||
| test: /\.css$/i, | ||
| use: [ | ||
| { | ||
| loader: 'postcss-loader', | ||
| options: { | ||
| sourceMap: !isProduction(), | ||
| postcssOptions: { | ||
| config: './postcss.config.js', | ||
| }, | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| }, |
There was a problem hiding this comment.
For more options, including how to configure url-loader, see https://github.com/evoactivity/ember-modern-css#webpack-configuration.
ijlee2
commented
Apr 10, 2023
Comment on lines
+6
to
+12
| /* | ||
| plugins.push( | ||
| require('cssnano')({ | ||
| preset: 'default', | ||
| }) | ||
| ); | ||
| */ |
There was a problem hiding this comment.
@buschtoens found that cssnano may not be needed anymore, because Embroider handles minifying CSS in production.
ijlee2
commented
Apr 10, 2023
Comment on lines
+27
to
+29
| export default interface Registry | ||
| extends EmberContainerQueryRegistry, | ||
| EmbroiderCssModulesRegistry { |
There was a problem hiding this comment.
This was referenced Apr 19, 2023
ijlee2
commented
May 1, 2023
Comment on lines
+29
to
+40
| mode: (resourcePath) => { | ||
| // The host app and active child addons are moved into a common | ||
| // stable temp dir (`options.workspaceDir`), before the `css-loader` | ||
| // processes them. | ||
| // | ||
| // We want to enable local mode only for our own host app. All other | ||
| // addons should be loaded in global mode. | ||
| const hostAppWorkspaceDir = `${options.workspaceDir}/${app.name}`; | ||
| const isHostAppPath = resourcePath.includes(hostAppWorkspaceDir); | ||
|
|
||
| return isHostAppPath ? 'local' : 'global'; | ||
| }, |
There was a problem hiding this comment.
I found a couple of cases where mode returns the incorrect value. Please see #188 for the bug fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
ember-css-modules, which lets us localize styles, is not fully compatible with Embroider. Since July 2022, @evoactivity and the Ember community have looked into how else we can implement CSS modules.About a couple of weeks ago, I began working on
embroider-css-modules, a set of tools and conventions to help people implement CSS modules. This pull request shows how people can migrate their apps.Notes
Commits 2 and 3 should be considered as one (1) step. I have them as separate to credit @buschtoens, who figured out how to more precisely define
css-loader'smode().Commit 7 shows three (3) types of optimizations, which I hand-rolled in order to improve readability and show areas where
ember-codemod-remove-ember-css-modulescould improve on in the future.