Improve Linux part, implement functions in libsddc and fix debug stacktrace read in firmware #196
Conversation
|
Hi Pavel, many thanks for sharing your code progress. I think Linux support is very important, unfortunately my personal knowledge of Linux is low. Fortunately Franco, Howard, Hayati have directed the code evolution to go in the direction of trying to offer support to the Linux world as well. |
|
appreciate your PR. |
|
Thanks for attention here, Howard and Oscar |
My pleasure. please cleanup and we can commit. I will also build a package for the libsddc for Linux/Windows for application to consume. |
Core/arch/linux/FX3handler.cpp
Outdated
| if(stream) { | ||
| // resume streaming | ||
| streaming_start(stream); | ||
| } |
There was a problem hiding this comment.
Here I was trying to avoid freezes when using device controls during active streaming. Now it freezes less, but not perfect, if anyone can suggest a better way to fix it I'll be glad.
There was a problem hiding this comment.
I looked at libusb code once. I am not expert. It is my suspicion that we didn't handle multi thread well. I suggest this page:
http://libusb.sourceforge.net/api-1.0/libusb_mtasync.html
There was a problem hiding this comment.
Oh yes, it looks like we have a situation described at the end of the article on your link. Thanks, I'll try to figure it out.
There was a problem hiding this comment.
I tried to figure out what happens in bulk transfers with libusb, but with no success. I found that streaming only works if there is a control transfers to the device (such as reading a debug trace), but under such conditions, all other controls are delayed by about a second. Without the control transfers bulk transfers timeouts, it looks like it tries to work when setting the transfer timeout to lowest possible 1ms, but this is not enough for full functionality anyway.
My competence is not enough to resolve this issue.
There was a problem hiding this comment.
Looks like I near solved this. Now it's possible to normally use streaming on linux, but sometimes streaming stops from libusb timeouts.
Also I was forced to reduce QUEUE_SIZE to 16 from 32, because with 32 I wasn't able get stable streaming with libusb.
Unfortunately, I can not test is something broke on Windows or not.
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for testing Oskar.
Hm, it's looking as in debug we have enabled reading debug from fx3 and this not works...
It's strange that without my change in firmware, reading not working good on Linux...
Anyway debug read on linux currently not working because of timeouts in streaming so I will just revert this change.
There was a problem hiding this comment.
I reverted changes in firmware, please check when you will have a time.
kpd200081
force-pushed
the
libsddc-imp
branch
4 times, most recently
from
0e96ab3
to
74854ca
Compare
kpd200081
force-pushed
the
libsddc-imp
branch
3 times, most recently
from
6620d9c
to
39777f7
Compare
Core/config.cpp
Outdated
| #include "config.h" | ||
|
|
||
| bool saveADCsamplesflag = false; | ||
| uint32_t adcnominalfreq = DEFAULT_ADC_FREQ; | ||
| uint32_t adcnominalfreq = DEFAULT_ADC_FREQ; |
There was a problem hiding this comment.
can we revert the changes in this file?
There was a problem hiding this comment.
Sorry, didn't notice this unrelated change in diff - reverted.
Core/config.h
Outdated
| @@ -1,7 +1,7 @@ | |||
| #ifndef _CONFIG_H_ | |||
| #define _CONFIG_H_ | |||
|
|
|||
| #include "license.txt" | |||
There was a problem hiding this comment.
all good changes but not related to linux usb. can we do these changes in a separate change?
There was a problem hiding this comment.
Reverted all except QUEUE_SIZE change
| { | ||
| return 0; | ||
| switch(t->samplerateidx) |
There was a problem hiding this comment.
sample rate is related to adc rate.
There was a problem hiding this comment.
Currently only two ADC rates supported in libsddc (64 and 128 MHz) and this relation handled here https://github.com/ik1xpv/ExtIO_sddc/blob/master/Core/RadioHandler.cpp#L154, isn't it?
|
only suggestion is revert the non-related style change. |
|
Please do not merge this yet, I found problem in streaming stopping. |
I would use libsddc for RX888 mk2 on Linux, but facing that a lot of functions not implemented and streaming was not working for me.
There are still some bugs and place for improvements, but I decide to share my progress with others.