Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issue in the definition of one_hot_encode_image_op, model/utils.py(P1) #13

Closed
DLPerf opened this issue Aug 27, 2021 · 2 comments

Comments

@DLPerf
Copy link

DLPerf commented Aug 27, 2021

Hello, I found a performance issue in the definition of one_hot_encode_image_op, model/utils.py, tf.zeros will be called repeatedly during program execution, resulting in reduced efficiency. I think it should be created before the loop.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

@lreiher
Copy link
Member

lreiher commented Sep 1, 2021

Hi, feel free to propose a PR. :) Would also be interesting to see whether this yields a performance improvement.

@lreiher
Copy link
Member

lreiher commented Jan 29, 2022

Closing due to inactivity.

@lreiher lreiher closed this as completed Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants