Merge pull request #58 from ika-rwth-aachen/feature/configure_node_name

Make ROS/ROS2 node name configurable via launch file
ika-rwth-aachen · Apr 8, 2024 · b0e6c06 · b0e6c06
2 parents 4380c8e + 0662918
commit b0e6c06
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/mqtt_client/config/params.ros2.yaml b/mqtt_client/config/params.ros2.yaml
@@ -1,4 +1,4 @@
-mqtt_client:
+/**/*:
   ros__parameters:
     broker:
       host: localhost

diff --git a/mqtt_client/launch/standalone.launch b/mqtt_client/launch/standalone.launch
@@ -1,8 +1,10 @@
 <launch>
 
+  <arg name="namespace" default="/" />
+  <arg name="node_name" default="mqtt_client" />
   <arg name="params_file" default="$(find mqtt_client)/config/params.yaml" />
 
-  <node pkg="nodelet" type="nodelet" name="mqtt_client" args="standalone mqtt_client/MqttClient" output="screen">
+  <node pkg="nodelet" type="nodelet" name="$(arg node_name)" ns="$(arg namespace)" args="standalone mqtt_client/MqttClient" output="screen">
     <rosparam command="load" file="$(arg params_file)" />
   </node>
 

diff --git a/mqtt_client/launch/standalone.launch.ros2.xml b/mqtt_client/launch/standalone.launch.ros2.xml
@@ -1,8 +1,10 @@
 <launch>
 
+  <arg name="namespace" default="" />
+  <arg name="node_name" default="mqtt_client" />
   <arg name="params_file" default="$(find-pkg-share mqtt_client)/config/params.ros2.yaml" />
 
-  <node pkg="mqtt_client" exec="mqtt_client" name="mqtt_client" output="screen">
+  <node pkg="mqtt_client" exec="mqtt_client" name="$(var node_name)" namespace="$(var namespace)" output="screen">
     <param from="$(var params_file)" />
   </node>