New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in ros1 latency deserialization #36

Merged

lreiher merged 1 commit into main from fix/ros1-latencies

Oct 4, 2023

Member

lreiher commented Oct 4, 2023

deserialization of message stamp was still expecting the stamp to start at index 1
this was the behavior before the ros2 refactoring, where the payload still included a bit indicating whether the time stamp was injected
now, the message type information that is being sent to the other client will include that information
related to how to detect latency #33


          fix bug in ros1 latency deserialization

5c369f0

introduced as part of refactoring for ros2 version

lreiher requested a review from bastilam

October 4, 2023 20:35

lreiher mentioned this pull request

how to detect latency #33

Closed

lreiher merged commit c000bf7 into main

18 checks passed

lreiher deleted the fix/ros1-latencies branch

October 4, 2023 20:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment