Release v2.3.0 #163
Merged
Release v2.3.0 #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverse merge for v2.2.2 from master to dev
* NeoPixelsLightStrip Added ability to interface with NeoPixels RGB LEDs. This will allow changing of Color, Brightness and State(On/Off) of the NeoPixels attached to the RPi. This accessory uses all available HomeKit Lightbulb API services (Hue, Saturation, Brightness). This commit requires the installation of rpi_ws281x library. The procedure is outlined in # https://learn.adafruit.com/neopixels-on-raspberry-pi/software. * Added check for RGB Tuple length to prevent crash from accessing outside bounds.
We need to call end_headers to flush the headers to the stream and this is done as part of end_response.
Look at camera_main.py for a quick start. * First steps in supporting a camera accessory. * Documentation; value serialization/deserialization * Commit progress * Various changes - iOS can negotiate sessions Running python3 cam.py and adding the camera in the Home app - iOS can negotiate stream config with HAP python, which then starts ffmpeg. Remaining issue is that the Home app gets stuck at "Loading..." * Code structure and documentation improvements. * Unit tests, ability to insert custom start stream command * Address flake8 warnings, disable some * Fix a bug in stop_stream, coding style * flake8 is now green * Polish camera_main.py, add test_camera.py * Add more camera tests * Fix lints
This change adds three methods that users can implement to plug custom logic for starting a stream, i.e. if only changing the start_stream_cmd does not fit. Added more tests.
* Spelling fix - executor * Updated changelog
Working camera #53 Probably missing edge cases, but can start/stop stream multiple times.
* Char - ignore duplicate values (client_update_value) * Added testcase * Updated logbook * Fix method name
The default Camera.start method now starts a process and redirects stdout to subprocess.DEVNULL and stderr to a subprocess.PIP. Also, on Camera.stop, the process is terminated (was killed) with a timeout of 2 seconds. If this expires, the process is killed. The stderr of the process is logged before the terminate. This change also documents how a camera accessory can be set up in the README.
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
==========================================
+ Coverage 52.08% 58.14% +6.05%
==========================================
Files 15 16 +1
Lines 1342 1639 +297
Branches 138 165 +27
==========================================
+ Hits 699 953 +254
- Misses 628 652 +24
- Partials 15 34 +19
|
|
Something might have gone wrong with this merge, maybe squash merge instead of a normal one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights:
set_characteristic