Merge char improvements, doc changes, version 1.1.9 #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump version to 1.1.8
* Merged set_value and get_hap_value * Small improvements * Added helper method '_validate_value' * Added helper method '_get_default_value' * Raise ValueError if properties are invalid * Added __slots__ * Additional changes * New method: update_value (use for value updates from HAP-python) * Rename: to_HAP to to_dict * New method: from_dict (use during loading of chars) * Addressed comments * Fixed errors, small mistakes * Added debug statements * Changed '_LOGGER' to 'logger' * Changed raise error to return None * Raising ValueErrors with custom msg * Bugfix, added additional logger.error statements * Rearanged functions * Added error_msg parameter * Added tests * Added '/htmlcov' to .gitignore
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
==========================================
+ Coverage 42.48% 44.22% +1.74%
==========================================
Files 12 12
Lines 1224 1230 +6
Branches 120 119 -1
==========================================
+ Hits 520 544 +24
+ Misses 691 676 -15
+ Partials 13 10 -3
|
|
@ikalchev Could you create a new release (for Github)? |
|
Done |
|
Thanks 👍 |
ikalchev
pushed a commit
that referenced
this pull request
Apr 25, 2018
* Remove breaking change description from README. * Characteristic improvements (#73) * Merged set_value and get_hap_value * Small improvements * Added helper method '_validate_value' * Added helper method '_get_default_value' * Raise ValueError if properties are invalid * Added __slots__ * Additional changes * New method: update_value (use for value updates from HAP-python) * Rename: to_HAP to to_dict * New method: from_dict (use during loading of chars) * Addressed comments * Fixed errors, small mistakes * Added debug statements * Changed '_LOGGER' to 'logger' * Changed raise error to return None * Raising ValueErrors with custom msg * Bugfix, added additional logger.error statements * Rearanged functions * Added error_msg parameter * Added tests * Added '/htmlcov' to .gitignore * Bump version number to 1.1.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.