Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix naming of sans family #23

Merged
merged 2 commits into from
May 4, 2022
Merged

Fix naming of sans family #23

merged 2 commits into from
May 4, 2022

Conversation

famasoon
Copy link
Contributor

@famasoon famasoon commented May 2, 2022

Fix #21

@ikanago
Copy link
Owner

ikanago commented May 4, 2022

Thank you for your work!
But some of the test fails due to the existing build error, so I'm going to investigate it ahead of review.
I'm going to create another PR fixing the problem, merge it toward main branch and re-run CI on this PR.

@ikanago ikanago force-pushed the 21-fix-naming-of-sans-family branch from 1bf07ec to f676e0b Compare May 4, 2022 02:10
@ikanago
Copy link
Owner

ikanago commented May 4, 2022 •
edited

Build error in CI on main branch must be solved on #24 , but the same error occurs... 🤔
The error was solved by refreshing the build cache on GitHub Actions and currently failing job on this PR uses the same cached artifacts.
So I have thought everything should go well, but...
Currently failing job and the job succeeded on main branch uses different cache artifact.
So I have to invalidate the current cache in some way.

@ikanago
Copy link
Owner

ikanago commented May 4, 2022

As a workaround, stopped using cache temporarily.

ikanago
ikanago approved these changes May 4, 2022
View reviewed changes
Copy link
Owner

@ikanago ikanago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just expected change.
Thank you for your contribution, famasoon 🙏

src/convert.rs
@@ -120,38 +120,38 @@ mod tests {
}

#[test]
fn sans_bold() {
fn bold_sans() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small but helpful fix 👍

@ikanago ikanago merged commit 616f373 into ikanago:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikanago ikanago ikanago approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix naming of sans family
2 participants
@famasoon @ikanago