Adjust for WAPM #27
Merged
Adjust for WAPM #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikanago
reviewed
May 16, 2022
| Font::Monospace, | ||
| Font::Blackboard, | ||
| ]) | ||
| Converter::new(Font::value_variants()) |
There was a problem hiding this comment.
I haven't known this feature. I don't have to check whether all the variants is enumerated here, thanks! 👍
ikanago
reviewed
May 16, 2022
Comment on lines
+63
to
+67
| let mut input = String::new(); | ||
| stdin().read_to_string(&mut input)?; | ||
| print!( | ||
| "{}", | ||
| converter.convert(&input.chars().collect::<Vec<_>>(), font) |
There was a problem hiding this comment.
This is the feature that I was going to implement! Thanks.
ikanago
approved these changes
May 16, 2022
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I wanted to throw omekasy onto wapm.io/webassembly.sh and adjusted it a bit for that (wasi doesn't support fancy terminal operations à la crossterm yet.)
This PR is more for asking whether you're opposed to that, than actually asking for these changes to be merged.