Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default adaptive step sizing feature and improve loggers #193

Merged
merged 11 commits into from
Dec 22, 2023

Conversation

tarun-mitruka
Copy link
Collaborator

No description provided.

@tarun-mitruka tarun-mitruka added bug Something isn't working enhancement New request to enhance existing features feature New feature labels Nov 14, 2023
@tarun-mitruka tarun-mitruka added this to the v0.4 milestone Nov 14, 2023
@tarun-mitruka tarun-mitruka marked this pull request as draft November 14, 2023 12:25
@tarun-mitruka tarun-mitruka force-pushed the feature/defaultAdaptiveStepSizing branch 4 times, most recently from 39f3b40 to db6d758 Compare November 14, 2023 14:31
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (ac14db0) 91.44% compared to head (1781cdf) 91.32%.

Files Patch % Lines
ikarus/utils/observer/observer.hh 21.42% 11 Missing ⚠️
ikarus/utils/observer/controlvtkwriter.hh 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   91.44%   91.32%   -0.13%     
==========================================
  Files          42       45       +3     
  Lines        1871     1879       +8     
==========================================
+ Hits         1711     1716       +5     
- Misses        160      163       +3     
Flag Coverage Δ
tests 91.32% <84.94%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarun-mitruka tarun-mitruka force-pushed the feature/defaultAdaptiveStepSizing branch 10 times, most recently from 14f5c98 to 6f8a553 Compare November 21, 2023 11:10
Co-authored-by: Anika Strauß <strauss@ibb.uni-stuttgart.de>
@tarun-mitruka tarun-mitruka force-pushed the feature/defaultAdaptiveStepSizing branch from f16b7e7 to 2152d28 Compare December 15, 2023 16:48
@tarun-mitruka tarun-mitruka force-pushed the feature/defaultAdaptiveStepSizing branch from ae460aa to 06c7a6c Compare December 20, 2023 13:39
@tarun-mitruka tarun-mitruka force-pushed the feature/defaultAdaptiveStepSizing branch 2 times, most recently from 41ba085 to ee6f976 Compare December 21, 2023 12:21
Copy link
Collaborator

@rath3t rath3t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@tarun-mitruka tarun-mitruka force-pushed the feature/defaultAdaptiveStepSizing branch from 487ce95 to 1781cdf Compare December 22, 2023 09:12
@tarun-mitruka tarun-mitruka merged commit ed4c177 into main Dec 22, 2023
15 of 17 checks passed
@tarun-mitruka tarun-mitruka deleted the feature/defaultAdaptiveStepSizing branch December 22, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New request to enhance existing features feature New feature
Projects
None yet
3 participants