Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor class documentation #220

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Refactor class documentation #220

merged 1 commit into from
Jan 8, 2024

Conversation

rath3t
Copy link
Collaborator

@rath3t rath3t commented Jan 2, 2024

No description provided.

@rath3t rath3t self-assigned this Jan 2, 2024
@rath3t rath3t added documentation Improvements or additions to documentation feature New feature labels Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 84 lines in your changes are missing coverage. Please review.

Comparison is base (1c8e1be) 91.32% compared to head (04337f5) 82.42%.
Report is 1 commits behind head on main.

Files Patch % Lines
ikarus/controlroutines/pathfollowing.inl 0.00% 32 Missing ⚠️
ikarus/utils/observer/observer.hh 43.33% 17 Missing ⚠️
ikarus/controlroutines/pathfollowingfunctions.hh 0.00% 7 Missing ⚠️
ikarus/controlroutines/pathfollowing.hh 0.00% 6 Missing ⚠️
...olver/newtonraphsonwithscalarsubsidiaryfunction.hh 0.00% 5 Missing ⚠️
ikarus/controlroutines/adaptivestepsizing.hh 0.00% 3 Missing ⚠️
ikarus/solver/nonlinearsolver/trustregion.hh 89.28% 3 Missing ⚠️
ikarus/utils/observer/controllogger.hh 0.00% 3 Missing ⚠️
ikarus/finiteelements/ferequirements.hh 86.66% 2 Missing ⚠️
ikarus/io/resultfunction.hh 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
- Coverage   91.32%   82.42%   -8.90%     
==========================================
  Files          45       47       +2     
  Lines        1879     1855      -24     
==========================================
- Hits         1716     1529     -187     
- Misses        163      326     +163     
Flag Coverage Δ
tests 82.42% <69.67%> (-8.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rath3t rath3t added this to the v0.4 milestone Jan 4, 2024
@rath3t rath3t linked an issue Jan 4, 2024 that may be closed by this pull request
@rath3t rath3t changed the title refactor assemblers Refactor class documentation Jan 5, 2024
@rath3t rath3t force-pushed the feature/adddoxygencomments branch 6 times, most recently from 87c5e2a to 624e82f Compare January 8, 2024 08:17
@rath3t rath3t merged commit acb4894 into main Jan 8, 2024
15 of 17 checks passed
@rath3t
Copy link
Collaborator Author

rath3t commented Jan 8, 2024

@tarun-mitruka Since, your last PR adds a heavy test which takes very long the coverage went done, since it is not tested anymore. Now Coverage only uses cpp_quick Ctest label. Can you write proper faster tests, i.e. some unit tests? Thanks!

rath3t added a commit that referenced this pull request Jan 8, 2024
@tarun-mitruka
Copy link
Collaborator

@tarun-mitruka Since, your last PR adds a heavy test which takes very long the coverage went done, since it is not tested anymore. Now Coverage only uses cpp_quick Ctest label. Can you write proper faster tests, i.e. some unit tests? Thanks!

Sure. Can you open a new issue for it? Else, it might get lost in the comments. Perhaps after #88, testadaptivestepsizing.cpp can be moved to cpp_quick, probably with some refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature New feature
Projects
None yet
2 participants