Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #298 gh action docker image build failure #301

Merged
merged 4 commits into from
May 9, 2023
Merged

fix #298 gh action docker image build failure #301

merged 4 commits into from
May 9, 2023

Conversation

KEINOS
Copy link
Sponsor Contributor

@KEINOS KEINOS commented May 9, 2023 •
edited

  • Fixes the build failure of Docker images
    • Use goreleaser for building Docker image (build-docker-latest.yml has benn merged to release.yml)
  • New features
    • Now the Docker image uses scratch (alpine -> scratch). More light and secure.
    • Support Arm v5 architecture for Linux and Docker.
    • Support Universal 2 (Universal Binary) for macOS.

@KEINOS KEINOS mentioned this pull request May 9, 2023
Closed
@KEINOS KEINOS force-pushed the fix-298-gh-action-docker branch from bffb202 to 2d29150 Compare May 9, 2023 03:13
@KEINOS KEINOS marked this pull request as ready for review May 9, 2023 03:25
@KEINOS
Copy link
Sponsor Contributor Author

KEINOS commented May 9, 2023

@ikawaha I have applied it for now. Please review when you got time!

@ikawaha ikawaha changed the base branch from v2 to develop May 9, 2023 10:44
@ikawaha
Copy link
Owner

ikawaha commented May 9, 2023

Great! Thank you!

@ikawaha ikawaha changed the base branch from develop to master May 9, 2023 10:45
@ikawaha ikawaha changed the base branch from master to v2 May 9, 2023 10:45
ikawaha
ikawaha approved these changes May 9, 2023
View reviewed changes
Copy link
Owner

@ikawaha ikawaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙆‍♀️

@ikawaha ikawaha merged commit 772362e into ikawaha:v2 May 9, 2023
@KEINOS KEINOS deleted the fix-298-gh-action-docker branch May 9, 2023 12:57
@3socha 3socha mentioned this pull request May 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikawaha ikawaha ikawaha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KEINOS @ikawaha