Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0 #7

Merged
merged 40 commits into from
Feb 28, 2021
Merged

3.0 #7

merged 40 commits into from
Feb 28, 2021

Conversation

ikbencasdoei
Copy link
Owner

@ikbencasdoei ikbencasdoei commented Feb 26, 2021

Updated to use the new merged AudioEffectCapture godotengine/godot#45593. (fixes #6)

Other changes and improvements include:

  • Voice is now transmitted every frame, improving delays and interruptions.
  • Incoming voice frames are played directly using an AudioStreamGenerator instead of using individual AudioStreamSamples, eliminating pops but introducing a delay.
  • Transmitted voice is mono instead of stereo, improving bandwidth. (fixes Set stereo to false #5)
  • Fixed memory leak associated with AudioEffectRecord.
  • Audio is transmitted using PoolRealArrays (32 bit).
  • Compatible with other mix rates.
  • Demo UI refactoring and improvements.
  • Added listen mode for testing and exported a few more variables.
  • Added input threshold parameter.
  • Added client/server IP and port inputs for demo

Any feedback is greatly appreciated!

@Gamemap
Copy link

Gamemap commented Feb 26, 2021

Is this lagging a bug or my bad microphone? (enable sound on video player)

2021-02-26-19-44-46.mp4

@ikbencasdoei
Copy link
Owner Author

ikbencasdoei commented Feb 26, 2021

Yeah that's a bug. Its worse than I expected. Probably have to look into this further.

@Gamemap
Copy link

Gamemap commented Feb 26, 2021

Ok, I am glad that the real time transmission works so well.

EDIT: I really like the Listen feature. Thank you!

@ikbencasdoei
Copy link
Owner Author

Updated to use AudioStreamGenerator instead of using AudioStreamSamples.

@Gamemap
Copy link

Gamemap commented Feb 27, 2021

The sound works very well. Is the latency a bit greater?

@ikbencasdoei
Copy link
Owner Author

Not sure why, but the AudioStreamGenerator does that.

@ikbencasdoei
Copy link
Owner Author

#7 (comment) #7 (comment) Another thing for the Godot team to fix. 😏 But for now I think it is worth it.

@Gamemap
Copy link

Gamemap commented Feb 27, 2021

Ok, thank you for this voice chat.

@Gamemap
Copy link

Gamemap commented Feb 27, 2021

#7 (comment) Is there already an issue or could you create one?

@ikbencasdoei
Copy link
Owner Author

I will create one

@Gamemap
Copy link

Gamemap commented Feb 28, 2021

Unfortunately, the latency is still (just a bit) greater than with the AudioStreamSamples, but I'm glad it's faster than before 3.2.4. So I can use it better now.

Thank you for this great, cool, usefull, impressive, wounderful Addon!
<3

@Gamemap
Copy link

Gamemap commented Mar 3, 2021

If it is possible and you have enough time and fun, it would be great if this low latency could also be fixed.

@ikbencasdoei
Copy link
Owner Author

I'm planning on fixing it in the next version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update 3.2.4 / 4.0 -> real time VoIP Set stereo to false
2 participants