Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweet is not blocked / Tweetがブロックされない #10

Closed
ikemo3 opened this issue Jun 18, 2019 · 2 comments
Closed

Tweet is not blocked / Tweetがブロックされない #10

ikemo3 opened this issue Jun 18, 2019 · 2 comments
Labels
bug Something isn't working urgent
Milestone
v1.8.2

Comments

@ikemo3
Copy link
Owner

ikemo3 commented Jun 18, 2019

とある人の名前で検索したときにtwitter.comをブロックしているにもかかわらずツイートが表示されてしまう。
@ikemo3 ikemo3 added bug Something isn't working urgent labels Jun 18, 2019
@ikemo3
Copy link
Owner Author

ikemo3 commented Jun 18, 2019 •
edited
Loading

調査結果

  • g-inner-cardのとき
  • ブロック自体はされているが、ブロック対象の判定が間違っている。 CSSの優先度の問題で、 display: none が無効化されている。

@ikemo3 ikemo3 closed this as completed in 59303b9 Jun 18, 2019
ikemo3 added a commit that referenced this issue Jun 18, 2019
@ikemo3
Merge pull request #11 from ikemo3/fix-tweet-is-not-blocked
d1771be 
fix tweet is not blocked. close #10
@ikemo3 ikemo3 added this to the v1.9.0 milestone Jun 18, 2019
@ikemo3
Copy link
Owner Author

ikemo3 commented Jun 18, 2019

CSSで !important をつけた。
通常は望ましくないが、プログラムの特性上これはいいでしょう・・・

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working urgent
Projects
None yet
Milestone
v1.8.2
Development

No branches or pull requests
1 participant
@ikemo3