Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweet is not blocked / Tweetがブロックされない #10

Closed
ikemo3 opened this issue Jun 18, 2019 · 2 comments

Comments

@ikemo3
Copy link
Owner

commented Jun 18, 2019

とある人の名前で検索したときにtwitter.comをブロックしているにもかかわらずツイートが表示されてしまう。

@ikemo3 ikemo3 added bug urgent labels Jun 18, 2019

@ikemo3

This comment has been minimized.

Copy link
Owner Author

commented Jun 18, 2019

調査結果

  • g-inner-cardのとき
  • ブロック自体はされているが、ブロック対象の判定が間違っている。 CSSの優先度の問題で、 display: none が無効化されている。

@ikemo3 ikemo3 closed this in 59303b9 Jun 18, 2019

ikemo3 added a commit that referenced this issue Jun 18, 2019
Merge pull request #11 from ikemo3/fix-tweet-is-not-blocked
fix tweet is not blocked. close #10

@ikemo3 ikemo3 added this to the v1.9.0 milestone Jun 18, 2019

@ikemo3

This comment has been minimized.

Copy link
Owner Author

commented Jun 18, 2019

CSSで !important をつけた。
通常は望ましくないが、プログラムの特性上これはいいでしょう・・・

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.