[DB] Allow DB::raw expressions as a value for mass update
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love this! |
Catch up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Allow passing in
DB::rawExpressionsso that the compiled CASE WHEN can use the current column values.How
Hook into
$valueinspection code and add a case forIlluminate\Contracts\Database\Query\Expressiontype. Pull out the raw string value by passing along the query's current grammar (Illuminate/Database/Query/Grammars/Grammar).Ex
Before this change, it would quote this value:
receipt_limit = 'receipt_limit - 1'which wasn't valid SQL syntax. With the change, it behaves as expected.