IKVM.Tool.Exporter #125
Merged
IKVM.Tool.Exporter #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a way of invoking IkvmExporter using a context: either an AppDomain or an AssemblyLoadContext. Because of how IKVM.Runtime works, loading types, programatic invocation of the stub generator can sort of pollute the runtime. So, isolating it prevents that. Should make it possible to run as a task at a later point.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ikvmstub is going to be known as the 'Exporter". Because it's really modeled after tlbexp and tlbimp from the COM world. Exporting a .NET assembly to Java, etc.
Most of the logic is moved to IKVM.Tool.Exporter, and then consumed from ikvmstub for now. Introduced an abstract to allow running the exporter in a 'context', such as an AppDomain or AssemblyLoadContext, which will allow programmatic invocation without polluting Universe/JVM. This is non ideal, but is required because of how IKVM.Runtime is structured currently.
Replaced ikvmstub's command line parsing with a System.CommandLine implementation. This is just cleaner. Preserves the existing operation (single -'s), but also allows -- and space separation POSIX style. An Options/Tool split can be used to invoke the tool programmatically.