Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid float formatting, which reduces binary size by 30k (5%) #48

Merged
merged 2 commits into from
May 7, 2020
Merged

Avoid float formatting, which reduces binary size by 30k (5%) #48

merged 2 commits into from
May 7, 2020

Conversation

malbarbo
Copy link
Contributor

@malbarbo malbarbo commented May 4, 2020

No description provided.

ilai-deutel
ilai-deutel reviewed May 5, 2020
View reviewed changes
Copy link
Owner

@ilai-deutel ilai-deutel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

src/editor.rs Outdated Show resolved Hide resolved
src/editor.rs Outdated Show resolved Hide resolved
@malbarbo
Copy link
Contributor Author

malbarbo commented May 6, 2020

I've update the format_size code.

ilai-deutel
ilai-deutel reviewed May 6, 2020
View reviewed changes
Copy link
Owner

@ilai-deutel ilai-deutel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there are two minor Travis errors (related to rustfmt and clippy) to fix and this will be good to go

@malbarbo
Copy link
Contributor Author

malbarbo commented May 6, 2020

Now travis is green!

ilai-deutel
ilai-deutel approved these changes May 7, 2020
View reviewed changes
Copy link
Owner

@ilai-deutel ilai-deutel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@ilai-deutel ilai-deutel merged commit fed4731 into ilai-deutel:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilai-deutel ilai-deutel ilai-deutel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malbarbo @ilai-deutel