Fixed bug when closing main window with unsaved changes (#135)

CHANGELOG.md

@@ -14,6 +14,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Show application version in About dialog
 - Support for yfinance module to fetch stocks data
 
+### Fixed
+- Fixed bug where main window was hidden when closing app with unsaved changes
+
 ## [2.1.1] - 2020-01-13
 ### Changed
 - Removed unused resource files

src/UI/gtk/UIHandler.py

@@ -57,7 +57,7 @@ def _create_UI(self):
         self._portfolio_path_label = builder.get_object(PORTFOLIO_PATH_LABEL)
         self._connection_status_image = builder.get_object(CONNECTION_IMAGE)
         # and link their callbacks
-        self._main_window.connect("destroy", self._on_close_main_window_event)
+        self._main_window.connect("delete-event", self._on_main_window_delete_event)
         open_button.connect("clicked", self._on_open_portfolio_event)
         settings_button.connect("clicked", self._on_open_settings_event)
         about_button.connect("clicked", self._on_show_about_event)
@@ -67,7 +67,7 @@ def _create_UI(self):
         for pf in self._client.get_portfolios():
             self._create_update_portfolio_tab(pf)
 
-    def _on_close_main_window_event(self, widget):
+    def _on_main_window_delete_event(self, widget, event):
         # Check if there are unsaved changes before closing the app
         if self._client.unsaved_changes():
             ConfirmDialog(
@@ -77,6 +77,9 @@ def _on_close_main_window_event(self, widget):
             ).show()
         else:
             self._close_application()
+            return False
+        # Return True to block event propagation
+        return True
 
     def _close_application(self):
         if self._log_window: