Support Literal (PEP 586) #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an `is_literal_type` API, and fixes `get_args` for literal types on 3.6 and 2.7 (provided by typing_extensions). This feature is in 3.8, but it's available as a backport to 3.7 and below as part of `typing_extensions`, so this adds `typing_extensions` as a dependency. I've tested this pull request by running the unit tests against Python 2.7, 3.6, and 3.7.
ilevkivskyi
approved these changes
Jul 3, 2019
|
I am going to close and re-open to trigger Travis build with new master. |
Closed
|
It looks like this missed adding a check in |
|
@anntzer Yes, the origin should be |
ilevkivskyi
pushed a commit
that referenced
this pull request
Jun 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
is_literal_typeAPI, and fixesget_argsfor literal types on 3.6 and 2.7 (provided bytyping_extensions).This feature is in 3.8, but it's available as a backport to 3.7 and below as part of
typing_extensions, so this addstyping_extensionsas a dependency.I've tested this pull request by running the unit tests against Python 2.7, 3.6, and 3.7.