-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMaZE not working right?? #47
Comments
You mean AMaZE artifacts are less in mlrawviewer and it's opposite in mlvapp right? |
I've been also thinking about it all the time from the beginning. I have no any idea why it's wrong though :( |
In mlrawviewer use srgb or re709 for comparison with mlv app, not og space as you both did :) btw exactly what color space we observing in the player of mlv app? |
thanks for the clips :) @bouncyball-git I found the 'HDR' mode in MLRawViewer was almost the same as MLV App's default tonemapped profile, so I did a direct comparison, tried to match them a bit: |
I always dreamed to use OpenColorIO for color management of my future application ;) now I can say "for our cutest MLV App". |
As for the images above: YES ugly artifacts are there and we have to understand why. |
It comes not from the processing. I disabled processing, exported a PNG and tried to process with another image tool. The artefacts are the same. |
OpenColourIO is worth looking at. Maybe will come to MLV App 😉 Who might know about how to fix this issue? Is there someone on the magic lantern forum who knows about this kind of thing? I really wish this could just get fixed already. |
We should ask there :) |
OpenColorIO would indeed be amazing to have it built in within the app. Seems like a long shot and shouldn’t be a priority while in this stage.
Though I can totally see/feel this one coming...
…Sent from my iPhone 5s
On Nov 19, 2017, at 10:11 AM, Ilia Sibiryakov ***@***.***> wrote:
OpenColourIO is worth looking at. Maybe will come to MLV App 😉
Who might know about how to fix this issue? Is there someone on the magic lantern forum who knows about this kind of thing? I really wish this could just get fixed already.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Yeah, we need to sort out the quality of the AMaZE debayerer first. |
http://www.magiclantern.fm/forum/index.php?topic=20995.msg193416#msg193416 |
Hmm.. iunteresting how to apply WB (matrix?) to the bayered data. Is it done during normalization? |
Hm... don't know if that is the reason. If I comment out WB, I would then expect a picture with wrong colors, but without artefacts. |
I dug into darktable's related code today, it's pure C and source is huge, OpenCL is used all over there for image processing and matrix applying. AMaZE is CPU based thought and works fantastic. If I switch WB off in the interface then greenesh familiar debayered unprocessed look appears on the screen and small aliasing artifacts can be seen on the edges (almos exactly like on our mlv app with processing object wholly disabled). After turning WB on in darktabe aliasing is almost gone even when sharpening is applied. |
No, it shouldn't be a matrix, as there's no way to blend the channels, just increase the value of red/blue pixels or decrease the green to get them equalised. I'll show what the results are soon. |
I'll try and put it right in to the AMaZE |
WOW! I am impressed! Congratulations! This is so much better, also with my other clips! |
maybe I'll leave this issue open for a little bit until I get the multipliers automated, as currently its most optimal for daytime white balance. |
Wow that's a great difference!!! Many shots will be saved. I was beginning to think that the 5D2 is completely doomed every time I used MLV App, but now that feeling will finally disappear :) |
Hey fantastic! I IS A REAL AMAZE!!! Hahaha I feel so better now too! :-D |
GREAT! Uhm... Can it be tuned little bit more? :P |
I had to play around with the new version... sry for that :-) |
Ни как не нарадуюсь как хорошо работает подлеченный AMaZE :-D. Спасибо! |
Compare MLV App with amaze and bilinear:
You can see amount of colour artifacts increases!!! ...or at least doesn't decrease
Now look at MLRawViewer amaze vs bilinear:
Artifacts of colour are reduced.
What might be wrong?
I have had this suspicion for such a long time, but MLRawViewer really pointed it out to me today.
The text was updated successfully, but these errors were encountered: