Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test failures with integers enabled #44

Open
radix opened this issue Dec 24, 2017 · 1 comment
Open

test failures with integers enabled #44

radix opened this issue Dec 24, 2017 · 1 comment
Milestone

Comments

@radix
Copy link
Contributor

radix commented Dec 24, 2017

I didn't realize that I didn't have integers enabled when running tests until I tried to write integer-specific tests for the new Saturating support I'm working on. When I tried to run them, I got these failures (with master, with u32 enabled):

    si::acceleration::tests::u32::check_units
    si::area::tests::u32::check_units
    si::force::tests::u32::check_units
    si::frequency::tests::u32::check_units
    si::velocity::test::u32::check_units
    si::volume::tests::u32::check_units
    tests::system_macro::op_assign::u32::sub_assign
    tests::system_macro::u32::sub

It seems that travis isn't running tests with ints enabled either.

@iliekturtles
Copy link
Owner

Known issue briefly mentioned in the v0.16.0 release notes. All the check_units failures are because conversion factors exceed the underlying storage type limits. Others like the u32::sub_assign and u32::sub failures are because quickcheck is generating test values that have a signed result once the operator is applied.

My plan is to implement PartialEq, Eq, PartialOrd, and Ord and then figure out how to resolve these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants