Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specific number rates: volumetric, areal, and linear. #338

Merged

Conversation

crystal-growth
Copy link
Contributor

Add specific number rates

  • Volumetric number rate [1 / (Volume x Time)]
  • Areal number rate [1 / (Area x Time)]
  • Linear number rate [1/ (Length x Time)]

Kind is ConstituentConcentrationKind

Typical applications:

  • molecule collision rate
  • carrier recombination rate in semiconductor (volumetric for bulk recombination, areal for surface recombination and linear for recombination in linear defect or quantum wire)
  • nucleation rate (volumetric for homogeneous nucleation, areal for heterogeneous nucleation on surface)

@iliekturtles
Copy link
Owner

I added a bunch of additional units to this one. Please review. Any more that you think should be added? Once you think things look good you can squash my changes into your commit: git rebase -i origin/master --autosquash. Let me know when that is done and I can do a final review and merge.

@crystal-growth
Copy link
Contributor Author

Thank you, I think now the set of units covers all possible practical problems. I've rebased and squashed the commit.

@iliekturtles iliekturtles merged commit 7c4b27b into iliekturtles:master Sep 3, 2022
@crystal-growth crystal-growth deleted the add_specific_number_rate branch September 3, 2022 14:02
@iliekturtles
Copy link
Owner

Everything I've reviewed so far has been merged! Thank you again for all these PRs. I'm going to try to get to the rest next week.

@crystal-growth
Copy link
Contributor Author

Thank you! I'll now delete merged branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants