fix(client): Accept nullish values for operationName and variables

ilijaNL · Oct 31, 2020 · 2d60dda · 2d60dda
1 parent fd207e8
commit 2d60dda
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/src/message.ts b/src/message.ts
@@ -101,10 +101,14 @@ export function isMessage(val: unknown): val is Message {
           hasOwnStringProperty(val, 'id') &&
           hasOwnObjectProperty(val, 'payload') &&
           (!hasOwnProperty(val.payload, 'operationName') ||
-            hasOwnStringProperty(val.payload, 'operationName')) &&
+            val.payload.operationName === undefined ||
+            val.payload.operationName === null ||
+            typeof val.payload.operationName === 'string') &&
           (hasOwnStringProperty(val.payload, 'query') || // string query or persisted query id
             hasOwnObjectProperty(val.payload, 'query')) && // document node query
           (!hasOwnProperty(val.payload, 'variables') ||
+            val.payload.variables === undefined ||
+            val.payload.variables === null ||
             hasOwnObjectProperty(val.payload, 'variables'))
         );
       case MessageType.Next:

diff --git a/src/tests/client.ts b/src/tests/client.ts
@@ -170,6 +170,31 @@ describe('query operation', () => {
 
     await sub.waitForComplete();
   });
+
+  it('should accept nullish value for `operationName` and `variables`', async () => {
+    const { url } = await startTServer();
+
+    const client = createClient({ url });
+
+    // nothing
+    await tsubscribe(client, {
+      query: 'query { getValue }',
+    }).waitForComplete();
+
+    // undefined
+    await tsubscribe(client, {
+      operationName: undefined,
+      query: 'query { getValue }',
+      variables: undefined,
+    }).waitForComplete();
+
+    // null
+    await tsubscribe(client, {
+      operationName: null,
+      query: 'query { getValue }',
+      variables: null,
+    }).waitForComplete();
+  });
 });
 
 describe('subscription operation', () => {